ctrl+c in a pager can break everything #124

Closed
georgebrock opened this Issue Mar 6, 2014 · 2 comments

Comments

Projects
None yet
2 participants
Owner

georgebrock commented Mar 6, 2014

To reproduce:

  1. Run a command that opens a pager (e.g. show HEAD)
  2. Hit ctrl+c
  3. The gitsh prompt is displayed, but the pager appears to still be running (e.g. pressing return will alternately show status output from gitsh, and (END) from the pager)
  4. Hit q a few times to kill the pager properly
  5. The terminal session is now broken; input won't be echoed at all
  6. Hit ctrl+d to exit gitsh
  7. The parent shell session is still broken
  8. Run reset to get back to a working state

@georgebrock georgebrock added the bug label Mar 6, 2014

Owner

mike-burns commented Mar 6, 2014

I can reproduce steps 1 to 5 using GNU libreadline. I could not exit using ^d, but could using :exit. My parent shell is fine.

Owner

georgebrock commented Mar 8, 2014

Closed in favour of #130.

@georgebrock georgebrock closed this Mar 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment