Completion after the dot would be seen as the beginning of a new argument. This is correct behaviour for two dots (e.g. HEAD~2..master) but not for one dot (e.g. fix-v1.4)
This should fix #87
There was more change to the spec file than I expected for a two character implementation change. The information like repo_head ended up being pretty far away in the file from the specs that test the dot-ness, so it is starting to feel a little Mystery Guest-y.
Other than maybe re-working that a little bit so there's separate describe blocks or a way to inject the v1.0 etc. bits from the dot spec, this looks good to me.
Thanks for the feedback, @croaky. I've refactored the spec and replaced the let blocks with a single factory method. The individual examples can pass in the setup they need to the factory method, which keeps the setup and the expectations nice and close and also is more in keeping with the style of other specs.
Very nice. I have a much better understanding of gitsh's completion functionality after reading the current spec.
Looks great! Ready to squash and merge at your discretion.
Fix tab completion for branches with a dot
Completion after the dot would be seen as a new branch name. This is correct
behaviour for two dots (e.g. HEAD~2..master) but not for one dot (e.g.
Includes a refactoring of the Completer unit spec, to reduce the amount of
Thanks, Dan. Squashed and merged.