Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 309 #310

Open
wants to merge 4 commits into
base: master
from
Open

Issue 309 #310

wants to merge 4 commits into from

Conversation

@cristianc-ty
Copy link

cristianc-ty commented Mar 27, 2019

A possible fix for issue #309.

An example file that reproduces the problem can be provided to the reviewer.

Performance improvement for Griddler::EmailParser
/^On.*<\r?\n?.*>.*\r?\n?wrote:\r?\n?$/,
/On.*wrote:/,
/\*?From:.*$/i,
/^[[:space:]]*\d{4}[-\/]\d{1,2}[-\/]\d{1,2}[[:space:]].*[[:space:]]<.*>?$/i,
/(_)*\n[[:space:]]*De :.*\n[[:space:]]*Envoyé :.*\n[[:space:]]*À :.*\n[[:space:]]*Objet :.*\n$/i, # French Outlook
/^[[:space:]]*\>?[[:space:]]*Le.*<\n?.*>.*\n?a[[:space:]]?\n?écrit :$/, # French
/^[[:space:]]*\>?[[:space:]]*El.*<\n?.*>.*\n?escribió:$/ # Spanish
/^[[:space:]]*(>[[:space:]]*)?Le.*<\n?.*>.*\n?a[[:space:]]?\n?écrit :$/, # French

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 27, 2019

Metrics/LineLength: Line is too long. [87/80]

# French
/^[[:space:]]*(>[[:space:]]*)?Le.*<\n?.*>.*\n?a[[:space:]]?\n?écrit :$/,
# Spanish
/^[[:space:]]*(>[[:space:]]*)?El.*<\n?.*>.*\n?escribió:$/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 27, 2019

Style/TrailingCommaInArrayLiteral: Put a comma after the last item of a multiline array.

# French
/^[[:space:]]*(>[[:space:]]*)?Le.*<\n?.*>.*\n?a[[:space:]]?\n?écrit :$/,
# Spanish
/^[[:space:]]*(>[[:space:]]*)?El.*<\n?.*>.*\n?escribió:$/

This comment has been minimized.

Copy link
@houndci-bot

houndci-bot Mar 27, 2019

Style/TrailingCommaInArrayLiteral: Put a comma after the last item of a multiline array.

@ashfurrow

This comment has been minimized.

Copy link

ashfurrow commented Oct 1, 2019

Hello! My colleague and I were running into a problem with our email systems and fixed it by pulling in this change (thank you, @cristianc-ty!). I'm not sure what the state of CI is for this PR (seems like some unrelated failures) but I would highly recommend reviewing this and getting it merged. This would likely also fix #264.

Thanks again for the project, and for the PR ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.