Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Mar 20, 2015
  1. @kaishin

    Revert hex value capitalization guideline

    kaishin authored kaishin committed
Commits on Mar 13, 2015
  1. @ryancoughlin
Commits on Mar 12, 2015
  1. @seanpdoyle

    Un-nest suggestions

    seanpdoyle authored
  2. @seanpdoyle
  3. @gabebw

    Do not put timestamps at the bottom of a migration

    gabebw authored
    `rails generate` puts timestamps at the bottom of a migration by default,
    meaning we have to change every migration even if the migration is otherwise
    generated perfectly.
    
    Original discussion: #159
Commits on Mar 10, 2015
  1. @seanpdoyle

    Ember-Data: Separate attributes and relations

    seanpdoyle authored seanpdoyle committed
    Ember-Data
    ----------
    
    * Visually separate relationships (`DS.{hasMany,belongsTo}`) from attributes (`DS.attr`).
    
    ```javascript
    export default DS.Model.extend({
      tags: DS.hasMany('tag'),
    
      title: DS.attr('string'),
    });
    ```
Commits on Mar 5, 2015
  1. @JuanitoFatas @jferris

    Fix spelling: "Objective-C", not "Objective C"

    JuanitoFatas authored jferris committed
Commits on Mar 3, 2015
  1. @BlakeWilliams

    Add JavaScript style guide

    BlakeWilliams authored
    * Add initial JavaScript style guide
    * Add ES6 to best practices via babel
Commits on Feb 23, 2015
  1. @jferris

    Guidelines for formatting Haskell pragmas

    jferris authored
    * With too many on one line, it gets ugly and you'll be forced to wrap.
    * You can be consistent if there's only one per line.
    * Use a blank line between pragma and module.
Commits on Feb 16, 2015
  1. @gylaz
Commits on Feb 13, 2015
  1. @gylaz

    Clarify how Rails associations should be ordered

    gylaz authored
    There are two options how the current wording can be interpreted. This changes
    the wording to favor the B option.
    
    Option A
    ```rb
    has_many :apples
    belongs_to :tree
    has_many :watermelons
    ```
    
    Option B
    ```rb
    belongs_to :tree
    has_many :apples
    has_many :watermelons
    ```
  2. @kaishin
Commits on Jan 30, 2015
  1. @tysongach
Commits on Jan 28, 2015
  1. @kylefiedler
  2. @brendastorer
Commits on Jan 26, 2015
  1. @croaky

    Update Hound's language support

    croaky authored
    We now support Ruby, JavaScript, CoffeeScript, and SCSS.
    Rather than needing to update this each time we add languages,
    don't be specific.
Commits on Jan 22, 2015
  1. @gabebw

    Prefer `if` over `unless`

    gabebw authored
  2. @penge @jferris

    Use double colons for pseudo-elements

    penge authored jferris committed
Commits on Jan 16, 2015
  1. @JoelQ

    Remove RSpec guideline for one-liners

    JoelQ authored
    Previously one-liners could be written in RSpec like:
    
        it { should validate_presence_of(:name) }
    
    In RSpec 3, the `should` syntax was removed because it monkey-patched `Object`.
    The one-liner syntax shown above was kept because its `should` did not
    monkey-patch `Object`. To avoid confusion, RSpec 3 added an `expect`-style way
    of writing one-liners:
    
        it { is_expected.to validate_presence_of(:name) }
    
    According to Myron Marston:
    
    > Some users have expressed confusion about how this should relates to the
    > expect syntax and if you can continue using it. It will continue to be
    > available in RSpec 3 (again, regardless of your syntax configuration), but
    > we’ve also added an alternate API that is a bit more consistent with the
    > expect syntax
    
    From: [New API for
    one-liners](http://myronmars.to/n/dev-blog/2014/05/notable-changes-in-rspec-3#new_api_for_oneliners_)
    
    A proposal was made to switch to using the new `is_expected.to` syntaxin [this
    pull request](#215). However, responses
    were mixed. Given the lack of consensus one way or the other, let's remove the
    guideline entirely and let each project decide which syntax to use.
  2. Merge branch 'sd-fix-typo'

    Steve Dixon authored
Commits on Jan 15, 2015
  1. @Keithbsmiley
Commits on Jan 14, 2015
  1. @Keithbsmiley
  2. @Keithbsmiley

    Remove outdated swift example

    Keithbsmiley authored
    Show example case
  3. @geoffharcourt @jferris

    Add convention for time without date columns

    geoffharcourt authored jferris committed
    Rails returns times without dates from the database as `Time` objects (as a time
    on the date `2000-01-01` in UTC), which can lead to confusion with actual
    datetimes. Although we can't make the returned value clearer, uniformly naming
    these columns with the suffix `_time` can at least remove confusion while
    reading the code.
  4. @JoelQ

    Break up style guide by language/framework

    JoelQ authored
    Our Styles guideline has grown large and cumbersome. It is over 400
    lines long and has 22 sections (some of which have several subsections.
    The directory structure looks like this:
    
        style
        ├── README.md
        └── samples
            ├── ObjectiveC.m
            ├── Swift.swift
            ├── acceptance_test.rb
            ├── android_layout.xml
            ├── backbone.coffee
            ├── coffee.coffee
            ├── erb.rb
            ├── haskell.hs
            ├── migration.rb
            ├── predicate_tests.rb
            ├── ruby.rb
            ├── sass.scss
            └── testing.rb
    
    In this commit, I've left some of the general section in the main README
    and broken out all of the language/framework-specific stuff into
    subdirectories, each with their own README and examples. The directory
    structure now looks like:
    
        style
        ├── README.md
        ├── android
        │   ├── README.md
        │   └── android_layout.xml
        ├── backbone
        │   ├── README.md
        │   └── sample.coffee
        ├── coffeescript
        │   ├── README.md
        │   └── sample.coffee
        ├── ember
        │   └── README.md
        ├── erb
        │   ├── README.md
        │   └── sample.html.erb
        ├── git
        │   └── README.md
        ├── haskell
        │   ├── README.md
        │   └── sample.hs
        ├── html
        │   └── README.md
        ├── objective_c
        │   ├── README.md
        │   └── sample.m
        ├── python
        │   └── README.md
        ├── rails
        │   ├── README.md
        │   └── migration.rb
        ├── ruby
        │   ├── README.md
        │   └── sample.rb
        ├── sass
        │   ├── README.md
        │   └── sample.scss
        ├── shell
        │   └── README.md
        ├── swift
        │   ├── README.md
        │   └── sample.swift
        └── testing
            ├── README.md
            ├── acceptance_test_spec.rb
            ├── predicate_tests_spec.rb
            └── unit_test_spec.rb
    
    This should make it easier to look up the relevant style guide as well
    as make it simpler to deal with multiple, smaller sample files for each
    language. This organization pattern would also support
    #261 very well.
    
    This commit simply changes the directory structure and breaks out
    sections of the style guide. Other refactorings that could build on this
    are:
    
    * Break up long lists of bullet points under several headings
    * Break up large example files into smaller more focused example files
Commits on Jan 13, 2015
  1. @graysonwright

    Define custom subjects as needed for one-liners

    graysonwright authored
    - Move custom subjects guideline to a best practice
    - Add `subject` examples to `style/samples/testing.rb`
    - Clarify when it's *not* okay to use `subject`
Commits on Jan 5, 2015
  1. @croaky
Commits on Dec 20, 2014
  1. @Keithbsmiley
Commits on Dec 19, 2014
  1. @mntj @mxie

    Remove typo from long variable name in ruby.rb

    mntj authored mxie committed
Commits on Dec 10, 2014
  1. @Keithbsmiley
  2. Fix typo.

    Steve Dixon authored
Commits on Nov 20, 2014
  1. @derekprior

    Prefer `reduce` over `inject`

    derekprior authored
    `reduce` provides symmetry with our already-preferred `map`.
    Additionally, it has a more intention-revealing name and is more
    approachable for people unfamiliar with it. "I am reducing this array to
    something". `inject` doesn't make the same sense.
Commits on Nov 7, 2014
  1. @drapergeek
Commits on Nov 6, 2014
  1. @drapergeek
Commits on Oct 9, 2014
  1. @penge @jferris

    Add missing links to samples

    penge authored jferris committed
Something went wrong with that request. Please try again.