Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index pages #27

Closed
wants to merge 2 commits into from
Closed

index pages #27

wants to merge 2 commits into from

Conversation

ludicast
Copy link

To help with breadcrumbs etc., I added an option for index pages. Say you visit e.g.

/pages/my_category

If high_voltage fails to locate the my_category.html view, the controller will also check:

/app/views/pages/my_category/index.html.erb

@mjankowski
Copy link
Contributor

I'm not opposed to something like this, just want to clarify the intention -- can you outline the use case where this functionality is useful?

@ludicast
Copy link
Author

When it comes down to it, it's really just for the aesthetics of high_voltage matching the way rails and webservers typically behave (i.e. with the resource at /users rendering /users/index.html.haml or /documentation serving /documentation/index.php).

I won't be too insulted if you don't accept the pull request though, as it is a minor feature.

@mike-burns
Copy link
Member

We've decided that, since we won't make use of this feature, it's best left out.

Thank you for the patch, though!
-Mike

@mike-burns mike-burns closed this Nov 16, 2011
@ludicast
Copy link
Author

No problem. Might as well keep HV lean and mean!

@mjankowski
Copy link
Contributor

It's the meanest!

@twe4ked twe4ked mentioned this pull request Jul 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants