Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Allow namespaced exceptions during rake hoptoad:test #10

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants

Trying something like EXCEPTION=Foo::Bar::Baz rake hoptoad:test would fail with NameError: wrong constant name Foo::Bar::Baz. This commit allows for testing of namespaced exceptions, though it won't create them in the event that they're missing.

Member

jyurek commented Mar 30, 2011

I'm unsure of why this is useful. Do you often need to do hoptoad tests with namespaced exceptions?

I believe I had added a namespaced exception to the ignore list and wanted to verify that I had done it properly. I don't often need to do Hoptoad tests in general, but figured if I ran into this, someone else probably would too.

Member

jyurek commented Mar 31, 2011

I think testing the ignores is a valid enough case that we can pull this in. Thanks!

@jyurek jyurek closed this Mar 31, 2011

@gabebw gabebw pushed a commit that referenced this pull request Oct 17, 2011

Gabe Berke-Williams Merge pull request #10 from Florent2/patch-1
Change Hoptoad references to Airbrake.
135065e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment