This repository has been archived by the owner. It is now read-only.

Upgrade to Rails 4 #7

Merged
merged 6 commits into from Nov 22, 2013

Conversation

Projects
None yet
2 participants
@gabebw
Contributor

gabebw commented Nov 18, 2013

This commit updates JackUp to Rails 4. Important points that I'd like your opinion on:

  • JackUp now requires Rails 4.0+
  • I removed the respond_to :json from the AssetsController in the dummy app. Was that important? The Remove respond_to :json commit explains my reasoning.

Gabe Berke-Williams added some commits Nov 18, 2013

Gabe Berke-Williams
Fixes for new version of Capybara
* Capybara looks in spec/features now
* Add selenium-webdriver to Gemfile
Gabe Berke-Williams
Clean up specs a bit
* Use expect syntax
* Use `have_css` instead of assuming `find` will not raise an exception
Gabe Berke-Williams
Remove respond_to :json
Setting the `JackUp.Processor` path to `/assets.json` made it not include the
file in the params. Without the `.json`, it correctly saved the Asset record
with the attached file, but then returned a 406 "content not acceptable" error
since the controller only responds to JSON, and it was processed as HTML.

This way it accepts the HTML request and returns JSON to JackUp.

@joshuaclayton joshuaclayton merged commit 645a20f into master Nov 22, 2013

@joshuaclayton joshuaclayton deleted the gbw-rails-4 branch Nov 22, 2013

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.