Don't push to a remote that doesn't exist. #69

Closed
wants to merge 15 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

bryan-ash commented Oct 14, 2011

Allows kumade to work without an 'origin' remote.

Closes #65

Contributor

gabebw commented Oct 14, 2011

Thanks for the pull request! Can you explain these commits a bit?

I'm not opposed to them, I'm just a bit confused. Is the problem that errors were not being printed and were instead being silently swallowed? If so, it looks like c27f13f fixes it?

Contributor

bryan-ash commented Oct 14, 2011

Yeah, I was confused too!

I wrestled for a while with strange failures in specs and a scenario. I was trying to add my change while disturbing as little as possible.

Apart from the fact that I don't know what the deploy branch is for, I think the Heroku actions could all be in a single call from Deployer, that way the "ensure" would be closer to the branch creation. I'm working on this right now, I'll share in a little while.

Contributor

gabebw commented Oct 14, 2011

The deploy branch is for asset packaging. The idea is to avoid 100s of "Compiled assets." commits just to get your Jammit-packaged assets into git (so that Heroku picks up on them). Those commits suck. So, create a deploy branch, package in there, and then push your local deploy branch to Heroku's master:

git push heroku deploy:master
Contributor

bryan-ash commented Oct 14, 2011

This might make more sense to me when I package assets. Now I need to go
play with that, thanks, like I didn't have enough to play with ;)

On Fri, Oct 14, 2011 at 5:22 PM, Gabe Berke-Williams <
reply@reply.github.com>wrote:

The deploy branch is for asset packaging. The idea is to avoid 100s of
"Compiled assets." commits just to get your Jammit-packaged assets into git
(so that Heroku picks up on them). Those commits suck. So, create a deploy
branch, package in there, and then push your local deploy branch to Heroku's
master:

git push heroku deploy:master

Reply to this email directly or view it on GitHub:
#69 (comment)

Contributor

gabebw commented Oct 14, 2011

Jammit is totally sweet. It's superseded by Sprockets in Rails 3.1, though.

Contributor

bryan-ash commented Oct 14, 2011

So, there should be a Kumade::SprocketsPackager?

On Fri, Oct 14, 2011 at 5:32 PM, Gabe Berke-Williams <
reply@reply.github.com>wrote:

Jammit is totally sweet. It's
superseded by Sprockets in Rails 3.1, though.

Reply to this email directly or view it on GitHub:
#69 (comment)

Contributor

bryan-ash commented Oct 14, 2011

https://github.com/bryan-ash/kumade/tree/heroku_deploy moves heroku deployment and cleanup down into Heroku class.

What do you think?

Contributor

gabebw commented Oct 15, 2011

No, there's no need for a Sprockets packager - Heroku on Cedar auto-packages as long as you've got the correct gems in your Gemfile. I'll take a look at your branch later - maybe make a pull request, just so I can more easily check out the differences? Thanks!

bryan-ash closed this Oct 22, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment