Heroku#cedar? check was totally broken. Fixed. #71

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

hoverlover commented Oct 16, 2011

Not sure how kumade was even working! Heroku#cedar?called CommandLine#run_or_error, and tried to #split it's output. The problem was that #run_or_error was directly returning #run's output, which was always either true or false, and is of course not a string and therefore cannot be split. The heroku shared context was mocking #run_or_error to return the output of the actual command, which is not what was being returned from #run.

Anyways, fixed now :)

Contributor

gabebw commented Oct 19, 2011

I'll take a look at this soon. Thanks for the catch!

Contributor

gabebw commented Oct 21, 2011

Hi, thanks for pointing this out. I've actually fixed this in 4b7358e - Cocaine::CommandLine returns the output by default, and I was ignoring that.

@gabebw gabebw closed this Oct 21, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment