Skip to content

Cleanup features #79

Merged
merged 17 commits into from Oct 28, 2011

2 participants

@gabebw
thoughtbot, inc. member
gabebw commented Oct 28, 2011

Test against generated Rails app for most things.

@gabebw gabebw commented on the diff Oct 28, 2011
lib/kumade/packager.rb
begin
@packager.package
- if @git.dirty?
+ if @git.dirty? || @git.has_untracked_files_in?(@packager.assets_path)
@gabebw
thoughtbot, inc. member
gabebw added a note Oct 28, 2011

Package untracked files, e.g. if public/assets were not tracked previously and Jammit.package! puts stuff in there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@mike-burns mike-burns commented on an outdated diff Oct 28, 2011
lib/kumade/packager.rb
@@ -21,11 +21,11 @@ module Kumade
end
def package
- return Kumade.configuration.outputter.success(success_message) if Kumade.configuration.pretending?
+ return Kumade.configuration.outputter.success(success_message) if Kumade.configuration.pretending? || @packager == NoopPackager
@mike-burns
thoughtbot, inc. member
mike-burns added a note Oct 28, 2011

What's going on here? Does this method do too much?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@gabebw gabebw merged commit ccfa677 into master Oct 28, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.