New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace node with nvm #456
Conversation
mandrean
commented
Apr 17, 2016
•
edited
edited
- Add NVM instead of just node. NVM then installs the latest stable node.
. "$(brew --prefix nvm)/nvm.sh" | ||
append_to_zshrc '#NVM' | ||
# shellcheck disable=SC2016 | ||
append_to_ashrc 'export NVM_DIR="$HOME/.nvm"' 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be append_to_zshrc
@angusfretwell sorry about that! fixed + squashed commits |
Node was already included, but python was not. Should these be separate pull requests? |
@blainesch Could you be more specific? This PR is more about installing node via nvm instead of just getting the latest version from homebrew. Devs often have to switch between different node versions... |
I'm suggesting adding |
I see! I can do that, np. |
* Fix shellcheck errors
@blainesch Sorry for late response! Forgot about this. OK now? |
We're already using |
@andersonvom I disagree... NVM is pretty much the golden standard these days with ~16 000 stars on GitHub vs nodenv with ~300. Not that it's always a good metric to use, but I think in this case it really speaks against nodenv. |
We used to have nvm in Laptop and removed it in #363. Asking around to see if others are using nvm at the moment. |
I do use it |
I use eval "$(pyenv init -)"
pyenv install --skip-existing 2.7.13
pyenv install --skip-existing 3.6.1
pyenv global 3.6.1 2.7.13
pyenv rehash eval "$(rbenv init -)"
rbenv install --skip-existing 2.4.1
rbenv global 2.4.1
rbenv rehash eval "$(nodenv init -)"
nodenv install --skip-existing 7.7.4
nodenv global 7.7.4
nodenv rehash |
nvm install stable | ||
nvm alias default stable | ||
# shellcheck disable=SC1090 | ||
. "$(brew --prefix nvm)/nvm.sh" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to come before nvm install stable
or you won't be able to find the nvm
command
@dplummer not true. However, |
I'm working on a branch to use |
See #502 |
https://github.com/asdf-vm/asdf-plugins Node listed as supported. |