Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace node with nvm #456

Closed
wants to merge 1 commit into from
Closed

Replace node with nvm #456

wants to merge 1 commit into from

Conversation

mandrean
Copy link

@mandrean mandrean commented Apr 17, 2016

  • Add NVM instead of just node. NVM then installs the latest stable node.

mac
. "$(brew --prefix nvm)/nvm.sh"
append_to_zshrc '#NVM'
# shellcheck disable=SC2016
append_to_ashrc 'export NVM_DIR="$HOME/.nvm"' 1

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be append_to_zshrc

@mandrean
Copy link
Author

@angusfretwell sorry about that! fixed + squashed commits

@bayleedev
Copy link

Node was already included, but python was not. Should these be separate pull requests?

@mandrean
Copy link
Author

mandrean commented Aug 5, 2016

@blainesch Could you be more specific? This PR is more about installing node via nvm instead of just getting the latest version from homebrew. Devs often have to switch between different node versions...

@bayleedev
Copy link

I'm suggesting adding pyenv should be it's own pull request. Node was previously installed by laptop, so that's an upgrade. Python was not, so that's a new feature.

@mandrean
Copy link
Author

mandrean commented Aug 5, 2016

I see! I can do that, np.

* Fix shellcheck errors
@mandrean
Copy link
Author

@blainesch Sorry for late response! Forgot about this. OK now?

@mandrean mandrean changed the title Replaced node with nvm, and added pyenv for both python2 & python3 Replace node with nvm Oct 27, 2016
@andersonvom
Copy link

We're already using rbenv and are about to add pyenv, so for consistency, wouldn't it be better to use nodenv instead of nvm?

@mandrean
Copy link
Author

mandrean commented Jan 14, 2017

@andersonvom I disagree... NVM is pretty much the golden standard these days with ~16 000 stars on GitHub vs nodenv with ~300.

Not that it's always a good metric to use, but I think in this case it really speaks against nodenv.

@croaky
Copy link
Contributor

croaky commented Feb 10, 2017

We used to have nvm in Laptop and removed it in #363. Asking around to see if others are using nvm at the moment.

@matchatype
Copy link

I do use it

@AlJohri
Copy link
Contributor

AlJohri commented Mar 30, 2017

I use nodenv regularly and its very stable, installable via homebrew (unlike nvm), and has feature parity with pyenv and rbenv which made scripting and usage easier for me.

eval "$(pyenv init -)"
pyenv install --skip-existing 2.7.13
pyenv install --skip-existing 3.6.1
pyenv global 3.6.1 2.7.13
pyenv rehash
eval "$(rbenv init -)"
rbenv install --skip-existing 2.4.1
rbenv global 2.4.1
rbenv rehash
eval "$(nodenv init -)"
nodenv install --skip-existing 7.7.4
nodenv global 7.7.4
nodenv rehash

mac
nvm install stable
nvm alias default stable
# shellcheck disable=SC1090
. "$(brew --prefix nvm)/nvm.sh"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to come before nvm install stable or you won't be able to find the nvm command

@mandrean
Copy link
Author

@dplummer not true. However, stable has been deprecated lately and should be replaced with node which it is currently an alias for.

@derekprior
Copy link
Contributor

I'm working on a branch to use asdf for version management. This will let us use one version manager for a whole host of languages and prevent us from having to install a new one with its own conventions for every language we get interested in.

@derekprior
Copy link
Contributor

See #502

@croaky
Copy link
Contributor

croaky commented Aug 4, 2017

https://github.com/asdf-vm/asdf-plugins Node listed as supported.

@croaky croaky closed this Aug 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants