Skip to content

Remove deprectated Heroku gem, add CLI client #45

Merged
merged 2 commits into from Nov 2, 2012

2 participants

@kevinSuttle

The Heroku gem has been deprecated, and Heroku recommends installing the client CLI from toolbelt.heroku.com. It's a binary, but you can install the "standalone" version (https://toolbelt.heroku.com/standalone) via wget.

Kevin Suttle Remove deprectated Heroku gem, add CLI client
The Heroku gem has been deprecated, and Heroku recommends installing the client CLI from toolbelt.heroku.com. It's a binary, but you can install the "standalone" version (https://toolbelt.heroku.com/standalone) via wget.
c5254cd
@gabebw
thoughtbot, inc. member
gabebw commented Nov 2, 2012

This installs git, right? Does that interfere with the git that I've installed via e.g. Homebrew? That's my only qualm about the Toolbelt.

@kevinSuttle

I looked through https://toolbelt.heroku.com/install.sh and the contents of http://assets.heroku.com.s3.amazonaws.com/heroku-client/heroku-client.tgz and found no references to Foreman or installing Git. The binary installers let you choose what to install, this is purely the Heroku CLI client. Also, if you look at what's included https://toolbelt.heroku.com/standalone vs https://toolbelt.heroku.com/osx (or /windows or /debian), they list Git and Foreman as being included. The standalone only lists the CLI client.

@gabebw gabebw commented on an outdated diff Nov 2, 2012
@@ -57,7 +57,10 @@ echo "Installing RVM (Ruby Version Manager) and Ruby 1.9.3, which becomes the de
successfully source ~/.zshenv
echo "Installing critical Ruby gems for Rails development ..."
- successfully gem install bundler rails heroku pg foreman thin --no-rdoc --no-ri
+ successfully gem install bundler rails pg foreman thin --no-rdoc --no-ri
+
+echo "Installing standalone Heroku CLI client. You'll need administrative rights on your machine ..."
+ successfully wget -qO- https://toolbelt.heroku.com/install.sh | sh
@gabebw
thoughtbot, inc. member
gabebw added a note Nov 2, 2012

wget isn't installed on OSX by default - can you change this to curl -so $URL instead?

Our dotfiles are targeted at OSX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@kevinSuttle

Sure. Note that curl -S https://toolbelt.heroku.com/install.sh | sh and curl https://toolbelt.heroku.com/install.sh | sh are the only commands that both download and run the file out of the combinations of -S and -O flags.

@gabebw
thoughtbot, inc. member
gabebw commented Nov 2, 2012

I meant lowercase s:

curl -s https://toolbelt.heroku.com/install.sh | sh

That runs it for me without printing the download progress from curl. Does it do something different for you?

Kevin Suttle Change wget to curl in Heroku CLI setup script
wget isn't pre-installed on OSX machines.
3ad4418
@kevinSuttle
@gabebw gabebw merged commit cc0751a into thoughtbot:master Nov 2, 2012
@kevinSuttle

Awesome. Thanks!

@gabebw
thoughtbot, inc. member
gabebw commented Nov 3, 2012

@kevinSuttle kevinSuttle deleted the kevinSuttle:patch-1 branch Feb 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.