humbly suggest managing heroku CLI with homebrew #67

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

michaelrkn commented Feb 12, 2013

No description provided.

echo "Installing the heroku-config plugin for pulling config variables locally to be used as ENV variables ..."
- successfully /usr/local/heroku/bin/heroku plugins:install git://github.com/ddollar/heroku-config.git
+ successfully heroku plugins:install git://github.com/ddollar/heroku-config.git
@gabebw

gabebw Feb 12, 2013

Contributor

Will this work without reloading the shell?

@michaelrkn

michaelrkn Feb 12, 2013

Contributor

In my testing it did.

@gabebw

gabebw Feb 13, 2013

Contributor

Works in ZSH too.

Contributor

michaelrkn commented Feb 12, 2013

Ooh, but I just realized I tested in bash, not zsh, so you might want to verify in zsh.

Contributor

croaky commented Feb 13, 2013

@michaelrkn Thanks for the pull request. Much appreciated.

Can you write a few words on the benefit of this approach? It seems like one downside is that Homebrew needs to be updated with each Heroku Toolbelt release and might fall behind:

https://github.com/mxcl/homebrew/commits/master/Library/Formula/heroku-toolbelt.rb

Contributor

michaelrkn commented Feb 13, 2013

Homebrew does have to be updated before updating the Heroku CLI, but that's also true of all the other programs Laptop installs with Homebrew. I like to manage everything through Homebrew if possible, so that I can update everything in one place. (It's also one reason (among others) I'm starting to switch to rbenv over rvm.)

Owner

joshuaclayton commented Feb 13, 2013

@croaky I'm not sure what point you're trying to make with the formula updating semi-regularly; if upgrading was crucial, the toolbelt would hopefully print out a warning and it's definitely easier to remember (and type) brew upgrade heroku-toolbelt than digging through the laptop script (or going to heroku's site) to figure out how to upgrade (do I have to uninstall? can I just re-run curl -s https://toolbelt.heroku.com/install.sh | sh?).

Contributor

croaky commented Feb 14, 2013

I like the uninstall/upgrade point, which is sort of like a subset of the "stick to a single package manager on your operating system" point.

Contributor

croaky commented Feb 14, 2013

@michaelrkn Thanks. Merged as 2b6ed80.

@croaky croaky closed this Feb 14, 2013

geoffharcourt added a commit to geoffharcourt/laptop that referenced this pull request Dec 1, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment