Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

humbly suggest managing heroku CLI with homebrew #67

Closed
wants to merge 1 commit into from

4 participants

Michael Kaiser-Nyman Dan Croak Joshua Clayton Gabe Berke-Williams
Michael Kaiser-Nyman

No description provided.

Gabe Berke-Williams gabebw commented on the diff
((8 lines not shown))
echo "Installing the heroku-config plugin for pulling config variables locally to be used as ENV variables ..."
- successfully /usr/local/heroku/bin/heroku plugins:install git://github.com/ddollar/heroku-config.git
+ successfully heroku plugins:install git://github.com/ddollar/heroku-config.git
Gabe Berke-Williams Admin
gabebw added a note

Will this work without reloading the shell?

In my testing it did.

Gabe Berke-Williams Admin
gabebw added a note

Works in ZSH too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Michael Kaiser-Nyman

Ooh, but I just realized I tested in bash, not zsh, so you might want to verify in zsh.

Dan Croak
Admin

@michaelrkn Thanks for the pull request. Much appreciated.

Can you write a few words on the benefit of this approach? It seems like one downside is that Homebrew needs to be updated with each Heroku Toolbelt release and might fall behind:

https://github.com/mxcl/homebrew/commits/master/Library/Formula/heroku-toolbelt.rb

Michael Kaiser-Nyman

Homebrew does have to be updated before updating the Heroku CLI, but that's also true of all the other programs Laptop installs with Homebrew. I like to manage everything through Homebrew if possible, so that I can update everything in one place. (It's also one reason (among others) I'm starting to switch to rbenv over rvm.)

Joshua Clayton

@croaky I'm not sure what point you're trying to make with the formula updating semi-regularly; if upgrading was crucial, the toolbelt would hopefully print out a warning and it's definitely easier to remember (and type) brew upgrade heroku-toolbelt than digging through the laptop script (or going to heroku's site) to figure out how to upgrade (do I have to uninstall? can I just re-run curl -s https://toolbelt.heroku.com/install.sh | sh?).

Dan Croak
Admin

I like the uninstall/upgrade point, which is sort of like a subset of the "stick to a single package manager on your operating system" point.

Dan Croak
Admin

@michaelrkn Thanks. Merged as 2b6ed80.

Dan Croak croaky closed this
Geoff Harcourt geoffharcourt referenced this pull request from a commit in geoffharcourt/laptop
Michael Kaiser-Nyman michaelrkn Manage Heroku CLI with Homebrew 624d6d6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 12, 2013
  1. Michael Kaiser-Nyman
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 3 deletions.
  1. +3 −3 mac
6 mac
View
@@ -69,11 +69,11 @@ echo "Installing RVM (Ruby Version Manager) and Ruby 1.9.3-p327, which becomes t
echo "Installing critical Ruby gems for Rails development ..."
successfully gem install bundler rails pg foreman thin --no-rdoc --no-ri
-echo "Installing standalone Heroku CLI client. You'll need administrative rights on your machine ..."
- successfully curl -s https://toolbelt.heroku.com/install.sh | sh
+echo "Installing standalone Heroku CLI client."
+ successfully brew install heroku-toolbelt
echo "Installing the heroku-config plugin for pulling config variables locally to be used as ENV variables ..."
- successfully /usr/local/heroku/bin/heroku plugins:install git://github.com/ddollar/heroku-config.git
+ successfully heroku plugins:install git://github.com/ddollar/heroku-config.git
Gabe Berke-Williams Admin
gabebw added a note

Will this work without reloading the shell?

In my testing it did.

Gabe Berke-Williams Admin
gabebw added a note

Works in ZSH too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
echo "Your shell will now restart in order for changes to apply."
exec $SHELL -l
Something went wrong with that request. Please try again.