Improve idempotence of script #88

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@croaky
Member
croaky commented Apr 9, 2013

No description provided.

@jferris
Member
jferris commented Apr 10, 2013

Nice. Looks good to me.

@croaky
Member
croaky commented Apr 10, 2013

Thanks, @jferris. Merged.

@croaky croaky closed this Apr 10, 2013
@gabebw gabebw commented on the diff Apr 10, 2013
@@ -65,7 +67,11 @@ echo "Installing watch, used to execute a program periodically and show the outp
echo "Installing rbenv for changing Ruby versions ..."
successfully brew install rbenv
- successfully echo 'eval "$(rbenv init -)"' >> ~/.zlogin
+
+ if ! [ grep -qs "rbenv init" ~/.zlogin ]; then
@gabebw
gabebw Apr 10, 2013 Member

Why does this need brackets around the condition but line 25 doesn't?

@croaky
croaky Apr 10, 2013 Member

@gabebw Good catch. They should not have brackets. Removed in 55d9853.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment