Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Auto-detect table layout #33

Closed
kaishin opened this Issue · 3 comments

2 participants

@kaishin
Admin

Currently, a table layout requires adding a table argument to each span-columns call. The solution would be detecting that the parent container/row is using a table layout instead.

@dukex

What do you detect the parent container?

I'm think work with scoped span-columns using sass blocks, like it:

div {
  @include outer-container (table) {
    section{
      @include span-columns(5)
    }
  }
}

We can define variables in outer-container and span-columns use it.

I don't know if it works very well, just thinking a way to resolve this problems

@kaishin
Admin

The problem with your suggestion is that it'll force the user to add the other styles for this div below the include and that may get confusing. I usually resort to globally-defined switch variables for this kind of situations. When a table argument is passed to outer-container or row, the variable is set to true, otherwise, it is set to false.

@kaishin
Admin

Closed in c5290ef

@kaishin kaishin closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.