Navigation Menu

Skip to content
This repository has been archived by the owner on Jul 14, 2023. It is now read-only.

Bourbon doc styles for Neat #173

Closed
wants to merge 6 commits into from
Closed

Conversation

smharley
Copy link

@smharley smharley commented Apr 8, 2014

  • updated bourbon files
  • navigation and social buttons
  • use typekit (proxima nova soft)
  • update old posts to use h4s
  • better favicon link for docs

image

SH navigation and social styles

SH use type kit

SH update old posts to use h4s

SH bourbon doc style

SH variables and compiled css

Better favicon link for docs
@conchan
Copy link

conchan commented Apr 8, 2014

Can I suggest that we change the link and social bar colors to match the Neat ones?

@smharley
Copy link
Author

smharley commented Apr 8, 2014

@conchan Orange -> Blue?

@conchan
Copy link

conchan commented Apr 8, 2014

Yeah. For the Bourbon docs, I took the hero gradient from the Bourbon homepage and used it for the social bar. Maybe the gradient from Neat's homepage could be used here.

And then for the links, yeah orange -> blue, and possibly for the currently-highlighted border color too?
screen shot 2014-04-08 at 1 57 21 pm

Just a suggestion! If you think it's ugly, then maybe not :)

@smharley
Copy link
Author

smharley commented Apr 8, 2014

image

@conchan
Copy link

conchan commented Apr 8, 2014

I digs it! Phil digs it!

@smharley
Copy link
Author

smharley commented Apr 8, 2014

Yeah, great idea, looks good!

@include button;
}

$button-width: 154px;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go into the variables stylesheet?

overflow: hidden;
}

&.docset {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is required because in the Dash docs (body.docset) there is no sidebar. So the doc area has to fill the entire page.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To verify, run rake docset then unzip neat.tgz. The page in question is in docset/Neat.docset/Contents/Resources/Documents/docset/index.html

@kaishin
Copy link

kaishin commented Apr 11, 2014

@smharley Thanks for the PR! Thanks @conchan for the review.

I've left a couple of comments regarding the docset and narrow layout. Other than those it looks good to me.

@conchan
Copy link

conchan commented Apr 11, 2014

On the Bourbon docs, I removed the device width tag and just let it load the page at a 960 min width IIRC. Phil and I agreed that the mobile view for the docs was never really considered in the first place and chances people need a mobile experience for it were low

@kaishin
Copy link

kaishin commented Apr 11, 2014

@conchan Agreed. But it's bad marketing for a grid framework that has a media() mixin. It looks more like oversight than an informed decision.

@conchan
Copy link

conchan commented Apr 11, 2014

Reda, you're so right!

@smharley
Copy link
Author

I don't think I'll have a chance to work on this for a while, will either of you have time?

@conchan
Copy link

conchan commented Apr 11, 2014

I wont :/ In a design sprint right into PTO! Will be out for about a week

SH update sass so !global doesn't error

SH responsive and small screen layout

SH add generated files
@smharley
Copy link
Author

I've updated the small screen and docset styles. @kaishin can you check to make sure the docset styles are being compiled/copied correctly? I was having trouble getting the rake docset to copy over the new docs.css. Thanks!

@kaishin
Copy link

kaishin commented Jul 23, 2014

This will be closed in favor of a better documentation solution. The current workflow in untenable.
I'm considering https://github.com/SassDoc/sassdoc and I have already started annotating new APIs with the documentation comments.

@kaishin kaishin closed this Jul 23, 2014
@kaishin
Copy link

kaishin commented Jul 23, 2014

To make sure we're on the same page, I will reuse the styles, but it's more likely to be on a separate repository/workflow.

@kaishin kaishin deleted the sh-bourbon-doc-styles branch November 7, 2014 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants