New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add style property to package.json, allowing for easier imports. #514

Merged
merged 4 commits into from May 12, 2017

Conversation

Projects
None yet
2 participants
@davejtoews
Contributor

davejtoews commented Nov 15, 2016

When installed via npm, a style property in package.json allows this module to be easily imported when using tools such as npm-sass or sass-module-importer.

Apparently the "style" key is not a standard, but it is a growing trend. Here's a StackOverflow thread on the subject: http://stackoverflow.com/questions/32037150/style-field-in-package-json

Update package.json
Add style property to package.json, allowing for easier imports.

@davejtoews davejtoews changed the title from Update package.json to Add style property to package.json, allowing for easier imports. Nov 15, 2016

davejtoews added some commits Nov 17, 2016

@whmii

This comment has been minimized.

Show comment
Hide comment
@whmii

whmii Mar 2, 2017

Member

@davejtoews the StackOverflow link you cited was from 2015 and mentions…

We're hoping to get this standardized at some point…

Is this actually used by any tooling?

Member

whmii commented Mar 2, 2017

@davejtoews the StackOverflow link you cited was from 2015 and mentions…

We're hoping to get this standardized at some point…

Is this actually used by any tooling?

@davejtoews

This comment has been minimized.

Show comment
Hide comment
@davejtoews

davejtoews Mar 2, 2017

Contributor

@whmii In addition to npm-sass and sass-module-importer mentioned above, it's also used by npm-css, rework-npm, npm-less, parcelify, and diamond, and It's been flagged as a "nice-to-have" feature in webpack's css-loader.

I made a similar PR on Bourbon, and you can see the discussion there.

Contributor

davejtoews commented Mar 2, 2017

@whmii In addition to npm-sass and sass-module-importer mentioned above, it's also used by npm-css, rework-npm, npm-less, parcelify, and diamond, and It's been flagged as a "nice-to-have" feature in webpack's css-loader.

I made a similar PR on Bourbon, and you can see the discussion there.

@whmii whmii merged commit 5f15317 into thoughtbot:master May 12, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
hound No violations found. Woof!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment