This repository was archived by the owner on Jul 14, 2023. It is now read-only.
Update node-sass version to 4.1.1 in order to support binaries for Alpine Linux#520
Closed
kazazor wants to merge 1 commit into
Closed
Update node-sass version to 4.1.1 in order to support binaries for Alpine Linux#520kazazor wants to merge 1 commit into
kazazor wants to merge 1 commit into
Conversation
Author
|
Once this PR will be merged, if approved, it should be as part of a patch version I didn't want to touch myself the updating of the patch version, I believe this is something that should be done by the owners of this repository. |
Update node-sass version to 4.1.1 in order to support binaries for Alpine Linux. We currently use version ^3.4 which is actually version 3.13.1 and according to the release notes of node-sass there are no breaking changes what so ever: https://github.com/sass/node-sass/releases/tag/v4.0.0 Github issue: #519
Author
|
This is really small commit, can someone please take a look at it so we could resolve the Alpine issue? |
Contributor
|
We have switched 2.0 to master so I am going to update this pr to point at https://github.com/thoughtbot/neat/tree/v1-stable |
Contributor
|
@kazazor LGTM, I'll merge this in tomorrow 👍 |
|
Just checking in on this, since it hasn't been merged yet. Also, is this a decision not to address #516? |
Contributor
|
Merged as 439db5d. |
Contributor
|
I just cut v1.9 which includes this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This solves #519.
We currently use version ^3.4 which is actually version 3.13.1 and according to the release notes of node-sass there are no breaking changes what so ever: https://github.com/sass/node-sass/releases/tag/v4.0.0