Skip to content
This repository has been archived by the owner. It is now read-only.

Update node-sass version to 4.1.1 in order to support binaries for Alpine Linux #520

Closed

Conversation

@kazazor
Copy link

@kazazor kazazor commented Jan 1, 2017

This solves #519.

We currently use version ^3.4 which is actually version 3.13.1 and according to the release notes of node-sass there are no breaking changes what so ever: https://github.com/sass/node-sass/releases/tag/v4.0.0

@kazazor
Copy link
Author

@kazazor kazazor commented Jan 1, 2017

Once this PR will be merged, if approved, it should be as part of a patch version 1.8.1.

I didn't want to touch myself the updating of the patch version, I believe this is something that should be done by the owners of this repository.

Update node-sass version to 4.1.1 in order to support binaries for Alpine Linux. We currently use version ^3.4 which is actually version 3.13.1 and according to the release notes of node-sass there are no breaking changes what so ever: https://github.com/sass/node-sass/releases/tag/v4.0.0

Github issue: thoughtbot#519
@kazazor kazazor force-pushed the kazaz/update_node_sass_verison branch from 573ed53 to 80fbd50 Jan 1, 2017
@kazazor
Copy link
Author

@kazazor kazazor commented Jan 3, 2017

This is really small commit, can someone please take a look at it so we could resolve the Alpine issue?

Copy link
Contributor

@tysongach tysongach left a comment

@whmii We could cut this as a 1.8.1 release.

@whmii
Copy link
Contributor

@whmii whmii commented Feb 28, 2017

We have switched 2.0 to master so I am going to update this pr to point at https://github.com/thoughtbot/neat/tree/v1-stable

@whmii whmii changed the base branch from master to v1-stable Feb 28, 2017
@whmii
Copy link
Contributor

@whmii whmii commented Mar 2, 2017

@kazazor LGTM, I'll merge this in tomorrow 👍

@rjbeers
Copy link

@rjbeers rjbeers commented Mar 15, 2017

Just checking in on this, since it hasn't been merged yet. Also, is this a decision not to address #516?

@tysongach
Copy link
Contributor

@tysongach tysongach commented Jun 27, 2017

Merged as 439db5d.

@tysongach tysongach closed this Jun 27, 2017
@tysongach
Copy link
Contributor

@tysongach tysongach commented Jun 27, 2017

I just cut v1.9 which includes this change.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants