Skip to content
This repository has been archived by the owner. It is now read-only.

Use Sass.load_paths instead of SASS_PATH env #612

Closed
wants to merge 1 commit into from
Closed

Conversation

@dgalarza
Copy link
Contributor

@dgalarza dgalarza commented Jun 23, 2017

#The SASS_PATH environment variable is not intended to be set by another
library but rather by consumers of Sass. Since the environment variable
is only read in once at the first time load_paths is called.

This was causing an error where, if a user had another gem such as
bootstrap-sass and it was being loaded before neat was, the
modifications to SASS_PATH we were making were never read in, so the
neat files would never be found.

See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43

@dgalarza dgalarza force-pushed the dg-sass-load-paths branch from 0ab07be to c3e5ac2 Jun 23, 2017
The SASS_PATH environment variable is not intended to be set by another
library but rather by consumers of Sass. Since the environment variable
is only read in once at the first time `load_paths` is called.

This was causing an error where, if a user had another gem such as
`bootstrap-sass` and it was being loaded before `neat` was, the
modifications to `SASS_PATH` we were making were never read in, so the
neat files would never be found.

See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43
@dgalarza dgalarza force-pushed the dg-sass-load-paths branch from c950dcd to d6bc594 Jun 26, 2017
@tysongach
Copy link
Contributor

@tysongach tysongach commented Jun 26, 2017

Oh, looks like #595 has this fixed, as well. Closing in favor of that since it was already open.

@tysongach tysongach closed this Jun 26, 2017
@dgalarza dgalarza deleted the dg-sass-load-paths branch Jun 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants