New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Sass.load_paths instead of SASS_PATH env #612

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@dgalarza
Contributor

dgalarza commented Jun 23, 2017

#The SASS_PATH environment variable is not intended to be set by another
library but rather by consumers of Sass. Since the environment variable
is only read in once at the first time load_paths is called.

This was causing an error where, if a user had another gem such as
bootstrap-sass and it was being loaded before neat was, the
modifications to SASS_PATH we were making were never read in, so the
neat files would never be found.

See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43

Damian Galarza
Use Sass.load_paths instead of SASS_PATH env
The SASS_PATH environment variable is not intended to be set by another
library but rather by consumers of Sass. Since the environment variable
is only read in once at the first time `load_paths` is called.

This was causing an error where, if a user had another gem such as
`bootstrap-sass` and it was being loaded before `neat` was, the
modifications to `SASS_PATH` we were making were never read in, so the
neat files would never be found.

See https://github.com/sass/sass/blob/1b628f03b9361fa6047097c9fd0d01b21247b8f3/lib/sass.rb#L20-L43
@tysongach

This comment has been minimized.

Show comment
Hide comment
@tysongach

tysongach Jun 26, 2017

Member

Oh, looks like #595 has this fixed, as well. Closing in favor of that since it was already open.

Member

tysongach commented Jun 26, 2017

Oh, looks like #595 has this fixed, as well. Closing in favor of that since it was already open.

@tysongach tysongach closed this Jun 26, 2017

@dgalarza dgalarza deleted the dg-sass-load-paths branch Jun 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment