Browse files

Remove Rubinius cache files for real this time.

  • Loading branch information...
1 parent 65a6ae8 commit 001fd99feff71509bd3227ac64ba3ca443dc931d @sikachu sikachu committed Dec 12, 2011
Showing with 1 addition and 1 deletion.
  1. +1 −1 features/step_definitions/attachment_steps.rb
View
2 features/step_definitions/attachment_steps.rb
@@ -15,7 +15,7 @@ class User < ActiveRecord::Base
#{definition}
end
FILE
- remove_file 'app/models/user.rbc' rescue nil
+ in_current_dir { FileUtils.rm_rf ".rbx" }
end
When /^I upload the fixture "([^"]*)"$/ do |filename|

5 comments on commit 001fd99

@dbussink

Is this needed for some reason to have it pass on Rubinius? If so, what is the reason for it? If there is an issue with having stale cache files that could indicate an issue in when the cache is invalided.

If this is just for cleaning up after yourself, there's probably no issue then.

@sikachu
thoughtbot, inc. member

There's an issue in the this test case: https://github.com/thoughtbot/paperclip/blob/master/features/rake_tasks.feature#L14-29

So the problem is that I modify the test app's app/models/user.rb and changing the size from 200x200 to 100x100 and Rubinius didn't recompile the file. Even I do write_file or shell out and touch the file after I changed it, it still ignore my change. (I verified this because I found "200x200" in that cached ruby file.) So, to make the test pass I have to do this.

@dbussink

Would you be able to create a small reproduction for us for this issue? If Rubinius doesn't recompile when it should, that definitely sounds like a bug we need to fix and that people shouldn't have to work around.

Preferable something that doesn't need a complex setup etc. but a script that's as simple as possible.

@sikachu
thoughtbot, inc. member
@dbussink

If the only reproducible case is a very complex one, so be it, but I'd hoped it would have been simpler then. What would be the complete setup needed step by step for reproducing this locally?

Please sign in to comment.