Permalink
Commits on May 25, 2018
  1. Rely on URI content_type only when provided.

    j15e authored and mike-burns committed Jul 18, 2016
    As described in #2118, `OpenURI::Meta#content_type` will return
    `application/octet-stream` when no `content-type` header is set. Using
    the original `meta` fixes this issue.
  2. Check for spoofing of files without an extension

    walterg2 authored and mike-burns committed Oct 21, 2016
    While using the Paperclip gem, we noticed during some ad-hoc testing
    that if you do not supply an extension when uploading a file, Paperclip
    effectively skipped it's spoofing check, which allowed potentially
    dangerous files to slip through into your application.
    
    This addresses that by moving the checks around a little bit and only
    testing against the extension when there is one.
  3. add is_windows to option

    aboutqx authored and mike-burns committed Nov 1, 2016
  4. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  5. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  6. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  7. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  8. Update geometry_detector_factory.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  9. Update geometry_detector_factory.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  10. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  11. Update geometry_detector_factory.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  12. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  13. Update geometry_detector_factory.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  14. Update processor.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  15. Update geometry_detector_factory.rb

    aboutqx authored and mike-burns committed Oct 31, 2016
  16. Skip validity check when reprocess attachment

    Amanda Munoz and Prem Sichanugrist authored and mike-burns committed Nov 18, 2016
    This validation was causing issue when there is no content_type column
    in the database, as the content type of the attachment would be empty.
    There should be no need to check attachment's validity because this
    `#reprocess!` method is running internally on the server.
    
    Fix #2078
Commits on May 18, 2018
  1. Better handling of the content-disposition header

    Whyves authored and mike-burns committed Feb 22, 2017
    Encountered an issue where the URI was returning header with
    content-disposition where the filename value wasn't enclosed in the
    double quotes. Turns out that this is a valid grammar according to
    RFC6266. Also made the logic more robust to account for spaces and
    uppercase letters.
  2. Ignore empty filename from content-disposition

    Hasan Kumar authored and mike-burns committed Apr 26, 2017
    e.g., the way google stores its user profile photos (from their oauth2 API)
    https://lh3.googleusercontent.com/-aRHQV4YjnBM/AAAAAAAAAAI/AAAAAAAAAAo/ngSjy9-yR5c/photo.jpg
  3. Remove magic comment

    hash52 authored and mike-burns committed Nov 22, 2017
    Since the support version is Ruby 2.0 or later, magic comment is unnecessary.
    
    > The UTF-8 default encoding, which make many magic comments omissible
    
    https://www.ruby-lang.org/en/news/2013/02/24/ruby-2-0-0-p0-is-released/
  4. Add ID_PARTITION_LIMIT with id above 999_999_999

    spk authored and mike-burns committed Mar 2, 2018
    This cause to erease previous image when the id change to above
    `999_999_999`, for example:
    
    ```
    2.3.6 :010 > id
     => 1000602578
    2.3.6 :011 > ("%09d".freeze % id).scan(/\d{3}/).join("/".freeze)
     => "100/060/257"
    ```
  5. Fix bug in migration instructions on MariaDB

    banjerluke authored and mike-burns committed May 17, 2018
    "key" is a reserved keyword in MariaDB, so the SQL statement fails.
    Surrounding the keyword in backticks fixes the error.
Commits on May 14, 2018
  1. Add deprecation notice to README (#2599)

    mike-burns authored and derekprior committed May 14, 2018
    * Add deprecation notice to README
    
    Addresses new projects, existing projects, issues, and PRs.
Commits on May 8, 2018
  1. Fix markdown typo (#2580) [ci skip]

    VikiAnn authored and sidraval committed May 8, 2018
    So that the `file_system` option renders correctly on the docs
Commits on May 7, 2018
  1. Handle already encoded URLs

    ivanoblomov authored and sidraval committed May 7, 2018
    Closes #2253
  2. Update UPGRADING (#2579)

    yskkin authored and sidraval committed May 7, 2018
    Follow #2481
  3. Test coverage for filenames with multiple periods

    ivanoblomov authored and sidraval committed May 7, 2018
    2254 coverage (#2395)
    
    * f(x): default to Paperclip::ContentTypeDetector
    
    * fix: failures
    
    * spec: cover consecutive periods
    
    * fix: hound
    
    * fix: hound
Commits on May 4, 2018