Skip to content
Commits on Jun 5, 2015
  1. @jyurek

    Fixes failing tests

    jyurek committed
Commits on Jan 6, 2015
  1. @jyurek

    Don't assume we have Rails.env if we have Rails

    jyurek committed
    As referenced in #1739
    
    Just because the `Rails` constant is defined, it doesn't mean we're
    actually in a Rails app. Since there are people who use Paperclip
    outside of Rails, and there's no reason we shouldn't be able to run in
    those situations. This commit checks for `Rails.env` instead of just
    checking for `Rails` and assuming `Rails.env` works.
Commits on Dec 5, 2014
  1. @jyurek

    Fog upgraded how expiring_urls are made

    jyurek committed
    Turns out that between fog 1.22.0 and fog 1.25.0, there was a change to
    how fog builds S3 expiring URLs. This changes to test to be the common
    point between the two versions. All we need to do here is make sure that
    the expiring URL is being constructed.
    
    In the process, this also updates all the appraisal-generated
    Gemfiles.
    
    Also, in the process, this meant I had to take away the builder version
    restriction. This was put in so that `bundle`ing wouldn't take forever,
    but I'm unsire whether this needed to happen with this version or if
    builder just needed to be separate from the Gemfile. I'm commimtting
    this and asking the people who reported the problem. If you don't see a
    revet commit, everything was fine.
  2. @jyurek

    Revert "remove whitespace, not main gemspec"

    jyurek committed
    This reverts commit 8d70c19.
  3. @jyurek

    Revert "Fog upgraded how expiring_urls are made"

    jyurek committed
    This reverts commit 8e0eb4c.
  4. @jyurek

    Fog upgraded how expiring_urls are made

    jyurek committed
    During the fixing of the previous commit, the tests broken. Turns out
    that between fog 1.22.0 and fog 1.25.0, there was a change to how fog
    builds S3 expiring URLs. This changes to test to be the common point
    between the two versions. All we need to do here is make sure that the
    expiring URL is being constructed.
    
    In the process, this also updates all the appraisal-generated Gemfiles.
    
    Also, in the process, this meant I had to take away the builder version
    restriction. This was put in so that `bundle`ing wouldn't take forever,
    but I'm unsire whether this needed to happen with this version or if
    builder just needed to be separate from the Gemfile. I'm commimtting
    this and asking the people who reported the problem. If you don't see a
    revet commit, everything was fine.
Commits on Mar 21, 2014
  1. @jyurek
Commits on Mar 11, 2014
  1. @jyurek

    Changes to get rbx passing

    jyurek committed
    First off, sqlite3 needs to be exactly v1.3.8.
    Need to make sure both racc and rubysl are in the Gemfiles.
    RBX's File.join doesn't like nil at all.
    RBX also doesn't like to remove a constant that doesn't exist yet.
  2. @jyurek

    Convert all of the tests from test/unit to RSpec

    jyurek committed
    This is a big one.
    
    This change converts all of the existing tests from test/unit to RSpec.
    It's been a long time coming, and was specifically prompted by the
    inability of minitest to work with Appraisal across the various Rails
    versions. Instead of ironing out that headache, converting to RSpec was
    preferable (after initial probing).
    
    Many assertions are still assertions and are housed in the Assertions
    module, but they should be converted as they get touched. Similarly,
    since we're touching all the tests/specs, we convert all the hashes from
    1.8 syntax to 1.9 syntax.
Commits on Feb 21, 2014
  1. @jyurek

    Add rubysl for rbx

    jyurek committed
Commits on Jan 29, 2014
  1. @jyurek
Commits on Jan 3, 2014
  1. @jyurek
Commits on Jul 31, 2013
  1. @jyurek
Commits on Jul 30, 2013
  1. @jyurek

    Getting tests to run in Rails 4

    jyurek committed
Commits on Sep 30, 2011
  1. @jyurek
Commits on Aug 23, 2011
  1. @jyurek
Commits on Jun 7, 2011
  1. @jyurek

    Updated Gemfiles

    jyurek committed
Commits on May 19, 2011
  1. @jyurek
Commits on Apr 6, 2011
  1. @jyurek

    Appraisal gemfile changes.

    jyurek committed
Commits on Nov 23, 2010
  1. @jyurek
Commits on Nov 22, 2010
  1. @jyurek
Something went wrong with that request. Please try again.