Skip to content
Commits on Mar 11, 2014
  1. @jyurek

    Convert all of the tests from test/unit to RSpec

    jyurek committed
    This is a big one.
    
    This change converts all of the existing tests from test/unit to RSpec.
    It's been a long time coming, and was specifically prompted by the
    inability of minitest to work with Appraisal across the various Rails
    versions. Instead of ironing out that headache, converting to RSpec was
    preferable (after initial probing).
    
    Many assertions are still assertions and are housed in the Assertions
    module, but they should be converted as they get touched. Similarly,
    since we're touching all the tests/specs, we convert all the hashes from
    1.8 syntax to 1.9 syntax.
Commits on Jan 31, 2014
  1. @jyurek

    Raise unless content type or name validation

    jyurek committed
    It is now a requirement for attachments to do one of three things:
      1. Have a content_type validation (e.g. "image/*")
      2. Have a filename validation (e.g. *.png, *.gif)
      3. Explicitly *not* have one of those validations
    
    The intent is to make the default more secure, and you have to
    explicitly reject the security of a validation in order to not have one.
Commits on Jan 29, 2014
  1. @jyurek

    A missing content_type validator shows deprecation warning

    Dan Collis-Puro committed with jyurek
  2. @jyurek
Commits on Jan 3, 2014
  1. @jyurek
Commits on Nov 1, 2013
  1. @jyurek

    Don't commit commented code.

    jyurek committed
  2. @jyurek
Commits on Oct 25, 2013
  1. @jyurek

    WIP

    jyurek committed
  2. @jyurek

    Print all the files!

    jyurek committed
Commits on Oct 8, 2013
  1. @sikachu

    Remove pry from gemspec for JRuby compatibility

    sikachu committed
    pry-debugger doesn't compile on JRuby, and we're really only using that
    locally.
Commits on Jul 31, 2013
  1. @jyurek

    Responses to PR comments

    jyurek committed
Commits on Jul 25, 2013
  1. @jyurek

    Return to full green with Rails 3

    jyurek committed
Commits on Jul 23, 2013
  1. @jyurek
Commits on Jul 18, 2013
  1. @printercu @jyurek

    fix for mocha's warning

    printercu committed with jyurek
Commits on Mar 8, 2013
  1. Clarify tests for frame dimensions

    Dan Collis-Puro committed
  2. @tiegz
Commits on Dec 4, 2012
  1. @kknapik @jyurek

    Add FakeModel#valid?

    kknapik committed with jyurek
Commits on Nov 16, 2012
  1. @jyurek
Commits on Oct 19, 2012
  1. @jyurek

    Translate bad filename characters

    jyurek committed
Commits on Sep 7, 2012
  1. @alanho @mike-burns
Commits on Jun 15, 2012
  1. @sikachu
Commits on May 4, 2012
  1. @sikachu
  2. @sikachu

    Cleanup integration test

    sikachu committed
    We've changed some of the setting and some of the S3 tests got ignored.
    This should make sure that the tests are really passing, after the
    changes to IO Adapter.
Commits on Apr 23, 2012
  1. @sikachu

    Update test helpers

    sikachu committed
    * Force column reset in Rails >= 3.1
    * Reuse another helper method
Commits on Apr 4, 2012
  1. @sikachu

    Fix a problem with `Rack::Test::UploadedFile`

    sikachu committed
    In Rails, `ActionDispatch::Http::UploadedFile` has an accessor to access
    a `Tempfile` object. However, `Rack::Test::UploadedFile` does not
    provide that, but provinding the `#path` method instead. To be able to
    support both, we have to check for existance for `#tempfile` method,
    then fallback to `#path` method.
    
    Fixes #807
Commits on Mar 30, 2012
  1. @sikachu

    Silence ALL the STDERR warnings!

    sikachu committed
  2. @jyurek

    Removed pry

    jyurek committed
  3. @jyurek

    Adds IO adapters to abstract the things that can be assigned.

    jyurek committed
    Needs work for S3 Attachments.
Commits on Mar 23, 2012
  1. @sikachu

    Add AttachementSizeValidator

    sikachu committed
  2. @sikachu
Commits on Mar 9, 2012
  1. @mike-burns

    Change the default :url and :path to avoid conflicts. Closes #727.

    mike-burns committed
    The new default :path and :include include the name of the model and
    also nests the model ID under a series of subdirectories, improving
    filesystem access speed when more than 1024 models have saved
    attachments.
    
    The easiest way to upgrade is to add an explicit :url and :path to your
    has_attached_file calls:
    
        has_attached_file :avatar,
          :path => ":rails_root/public/system/:attachment/:id/:style/:filename",
          :url => "/system/:attachment/:id/:style/:filename"
Commits on Feb 3, 2012
  1. @Sporky023
  2. @Sporky023
Commits on Dec 12, 2011
  1. @sikachu

    Use Net::HTTP instead of curl

    sikachu committed
    There was some problem with command line parsing with a special character.
Commits on Nov 16, 2011
  1. @mike-burns
Something went wrong with that request. Please try again.