Skip to content

Loading…

Storage::S3.parse_credentials depends on Rails unnecessarily #389

Closed
whittle opened this Issue · 1 comment

2 participants

@whittle

Since breaking up an S3 credentials file into Rails environments is already optional, use of Rails is easily made optional as well.

https://github.com/whittle/paperclip/blob/master/lib/paperclip/storage/s3.rb

All tests pass, no tests added. Would a non-Rails appraisal be valuable?

@sikachu
thoughtbot, inc. member

Do you mind rebase your patch and send as proper pull request?

I wonder how it would be used without Rails framework though.

@sikachu sikachu added a commit that closed this issue
Jason Whittle Make Storage::S3.parse_credentials use of Rails.env optional.
Closes #389, Closes #390
ff0910d
@sikachu sikachu closed this in ff0910d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.