filenames with question marks + expiring s3 url = pain

[xxx]

We are seeing an issue where filenames that include question marks cannot be linked to with expiring urls because the question mark in the filename is being treated as the beginning of the url query string.

I'm not sure what the best path for fixing this one is.

[sikachu]

I can see the potential failure there. Can you provide us with a failing test case. It's going to be a bit tricky though, as we're actually delegating to aws/s3 for expiring url generation.

[xxx]

Yes, I just sent a pull request - #621

[xxx]

Is there a preferred method to resolve this? I have some bandwidth to work on it, but I don't want to make a fix that can't be merged in.

[sikachu]

I've fixed this one after switch to aws/sdk. I've test cases to cover this, so I think this should be resolved.