Paperclip#run doesn't respect options[:swallow_stderr] #741

Closed
apolzon opened this Issue Feb 15, 2012 · 0 comments

Comments

Projects
None yet
2 participants
@apolzon

apolzon commented Feb 15, 2012

Paperclip#options[:swallow_stderr] defaults to true, but is never used in Paperclip#run.

It is very misleading to allow users to configure paperclip to swallow stderr, but never have that option properly passed to Cocaine in Paperclip#run.

Pull request to follow which will merge in options[:swallow_stderr] to local_options.

apolzon pushed a commit to apolzon/paperclip that referenced this issue Feb 15, 2012

@sikachu sikachu closed this Feb 17, 2012

sikachu added a commit that referenced this issue Feb 17, 2012

Merge pull request #742 from apolzon/respect_swallow_stderr_option_wh…
…en_running_commands

Paperclip#run now respects swallow_stderr setting. Fix for #741

mike-burns added a commit that referenced this issue Feb 24, 2012

Revert "Paperclip#run now respects swallow_stderr setting. Fix for #741"
This reverts commit 58671eb.

I am reverting this because the tests broke and because the code itself
looks hideous.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment