Adds expiring_url as an alias for url to attachment #1187

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@aarellano
Contributor

aarellano commented Mar 8, 2013

If the expiring_url method is used when the storage is S3 or fog, the filesystem is no longer an option, since it doesn't declare this method. This situation forces you to use the cloud storage option in all the environments.

Having this simple alias allows you to use S3 or fog for production, and keep using the filesystem option for development and/or testing.

@jyurek

This comment has been minimized.

Show comment Hide comment
@jyurek

jyurek Mar 8, 2013

Contributor

This makes a lot of sense, but can you add a test for it?

Contributor

jyurek commented Mar 8, 2013

This makes a lot of sense, but can you add a test for it?

@aarellano

This comment has been minimized.

Show comment Hide comment
@aarellano

aarellano Mar 9, 2013

Contributor

should I care about the Travis build result? I don't get those errors when running the test suite locally...

Contributor

aarellano commented Mar 9, 2013

should I care about the Travis build result? I don't get those errors when running the test suite locally...

@jyurek

This comment has been minimized.

Show comment Hide comment
@jyurek

jyurek Mar 15, 2013

Contributor

No, the tests pass for me too, so it's fine. Thanks for this, merged it in!

Contributor

jyurek commented Mar 15, 2013

No, the tests pass for me too, so it's fine. Thanks for this, merged it in!

@jyurek jyurek closed this Mar 15, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment