Skip to content

Adds expiring_url as an alias for url to attachment #1187

Closed
wants to merge 3 commits into from

2 participants

@aarellano

If the expiring_url method is used when the storage is S3 or fog, the filesystem is no longer an option, since it doesn't declare this method. This situation forces you to use the cloud storage option in all the environments.

Having this simple alias allows you to use S3 or fog for production, and keep using the filesystem option for development and/or testing.

@jyurek
thoughtbot, inc. member
jyurek commented Mar 8, 2013

This makes a lot of sense, but can you add a test for it?

@aarellano

should I care about the Travis build result? I don't get those errors when running the test suite locally...

@jyurek
thoughtbot, inc. member
jyurek commented Mar 15, 2013

No, the tests pass for me too, so it's fine. Thanks for this, merged it in!

@jyurek jyurek closed this Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.