Animated GIF support #454

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@factore

factore commented Apr 21, 2011

I added support for animated gif resizing while maintaining status-quo for all other file types (notably PDF) – it just checks if the file is a gif or not before appending the [0] to the file source.

@openface

This comment has been minimized.

Show comment
Hide comment
@openface

openface May 26, 2011

Any chance for this to make it into main? Having a way to preserve a GIF's animation with Paperclip would be an important feature imo.

Any chance for this to make it into main? Having a way to preserve a GIF's animation with Paperclip would be an important feature imo.

@mcfiredrill

This comment has been minimized.

Show comment
Hide comment
@mcfiredrill

mcfiredrill May 30, 2011

Contributor

This is a feature I need as well. I am just using SeanRobert's commit until this gets into main.

Contributor

mcfiredrill commented May 30, 2011

This is a feature I need as well. I am just using SeanRobert's commit until this gets into main.

@nikolas

This comment has been minimized.

Show comment
Hide comment

nikolas commented May 30, 2011

\o/

@openface

This comment has been minimized.

Show comment
Hide comment
@openface

openface May 31, 2011

I ended up writing a custom processor called "PreserveAnimatedGifs" that essentially does what this commit does. I have to presume that this is the proper way to handle animated GIFs with paperclip.

I ended up writing a custom processor called "PreserveAnimatedGifs" that essentially does what this commit does. I have to presume that this is the proper way to handle animated GIFs with paperclip.

@SeanRoberts

This comment has been minimized.

Show comment
Hide comment
@SeanRoberts

SeanRoberts Jun 14, 2011

I agree, are you going to submit a pull request? Or make it available elsewhere?

Also, do you have to specifically invoke that processor on each Paperclip attachment? Because I would argue that the default behaviour should be to preserve animated gifs.

I agree, are you going to submit a pull request? Or make it available elsewhere?

Also, do you have to specifically invoke that processor on each Paperclip attachment? Because I would argue that the default behaviour should be to preserve animated gifs.

@sikachu sikachu closed this in 119a44b Jun 20, 2011

@sikachu

This comment has been minimized.

Show comment
Hide comment
@sikachu

sikachu Jun 20, 2011

Contributor

I've commit a fix for it, as there's no test from your patch and I think it's better to move the detection elsewhere. Please test it and see if it fixes your issues.

Contributor

sikachu commented Jun 20, 2011

I've commit a fix for it, as there's no test from your patch and I think it's better to move the detection elsewhere. Please test it and see if it fixes your issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment