Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

s3_host_alias configurable via yml file #475

Closed
wants to merge 1 commit into from

6 participants

@hampei

s3_host_alias is basically the same as bucket in that it is dependent on Rails.env just as often.

@sikachu
Owner

Do you mind adding a test for this? We can't accept your patch if there's no test with it.

Thank you.

@mike-burns
Owner

Hi @hampei, any update on this?

@stefankutko

+1 for getting this integrated

@mike-burns
Owner

Closing due to inactivity. Please re-open or submit a new pull request as needed.

Thanks,
-Mike

@mike-burns mike-burns closed this
@latensified

I would like to see this as well.

@shem8

Me too, we use a different host for development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on May 12, 2011
  1. made s3_host_alias configurable via yml

    Henk van der Veen authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 1 deletion.
  1. +1 −1  lib/paperclip/storage/s3.rb
View
2  lib/paperclip/storage/s3.rb
@@ -73,7 +73,7 @@ def self.extended base
@s3_permissions = @options[:s3_permissions] || :public_read
@s3_protocol = @options[:s3_protocol] || (@s3_permissions == :public_read ? 'http' : 'https')
@s3_headers = @options[:s3_headers] || {}
- @s3_host_alias = @options[:s3_host_alias]
+ @s3_host_alias = @options[:s3_host_alias] || @s3_credentials[:s3_host_alias]
unless @url.to_s.match(/^:s3.*url$/)
@path = @path.gsub(/:url/, @url)
@url = ":s3_path_url"
Something went wrong with that request. Please try again.