Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixes AWS::S3::Errors::RequestTimeout on Model#save #811

Merged
merged 3 commits into from Apr 5, 2012

Conversation

Projects
None yet
2 participants
Contributor

brumm commented Apr 5, 2012

Setting binmode on tempfiles correctly sets the tempfiles external_encoding to ASCII-8BIT instead of UTF-8, which aws-sdk choked on.

I'm not entirely sure whether it's necessary to set binmode on all possible adapters, but I did it anyway to be sure. Tests are passing and new tests are added.

Contributor

sikachu commented Apr 5, 2012

This does make sense. Let's see if it fixes the issue.

sikachu added a commit that referenced this pull request Apr 5, 2012

Merge pull request #811 from brumm/master
Fixes AWS::S3::Errors::RequestTimeout on Model#save

@sikachu sikachu merged commit 818281d into thoughtbot:master Apr 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment