Skip to content

Commit 1e35c68

Browse files
committed
Remove duplication in Answer
* Removes smell Duplicated Code * Applies refactoring Extract Method
1 parent 8698fd4 commit 1e35c68

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

Diff for: example_app/app/models/answer.rb

+8-3
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,16 @@ class Answer < ActiveRecord::Base
77
validates :text, presence: true
88

99
def self.for_user(user)
10-
joins(:completion).where(completions: { user_id: user.id }).last ||
11-
NullAnswer.new
10+
joins(:completion).where(completions: { user_id: user.id }).last_or_null
1211
end
1312

1413
def self.most_recent
15-
order(:created_at).last || NullAnswer.new
14+
order(:created_at).last_or_null
15+
end
16+
17+
private
18+
19+
def self.last_or_null
20+
last || NullAnswer.new
1621
end
1722
end

0 commit comments

Comments
 (0)