Replace Subclasses with Strategies: Step Five

* Pass strategy instead of subclass when only the strategy is needed
* Don't delegate strategy-specific behavior from subclasses

Author: jferris

example_app/app/models/multiple_choice_question.rb

@@ -3,10 +3,6 @@ class MultipleChoiceQuestion < Question
 
   accepts_nested_attributes_for :options, reject_if: :all_blank
 
-  def options_for_form
-    submittable.options_for_form
-  end
-
   def submittable
     MultipleChoiceSubmittable.new(self)
   end

example_app/app/models/scale_question.rb

@@ -2,10 +2,6 @@ class ScaleQuestion < Question
   validates :maximum, presence: true
   validates :minimum, presence: true
 
-  def steps
-    submittable.steps
-  end
-
   def submittable
     ScaleSubmittable.new(self)
   end

example_app/app/views/multiple_choice_questions/_multiple_choice_question_form.html.erb

@@ -1,3 +1,3 @@
-<%= form.fields_for(:options, question.options_for_form) do |option_fields| -%>
+<%= form.fields_for(:options, submittable.options_for_form) do |option_fields| -%>
   <%= option_fields.input :text, label: 'Option' %>
 <% end -%>

example_app/app/views/questions/_form.html.erb

@@ -1,6 +1,10 @@
 <%= simple_form_for question, as: :question, url: url do |form| -%>
   <%= form.hidden_field :type %>
   <%= form.input :title %>
-  <%= render "#{question.to_partial_path}_form", question: question, form: form %>
+  <%= render(
+    "#{question.to_partial_path}_form",
+    submittable: question.submittable,
+    form: form
+  ) %>
   <%= form.submit %>
 <% end -%>

example_app/app/views/scale_questions/_scale_question.html.erb

@@ -1,5 +1,5 @@
 <ol>
-  <% scale_question.steps.each do |step| -%>
+  <% submittable.steps.each do |step| -%>
     <li>
       <%= submission_fields.radio_button :text, step %>
       <%= submission_fields.label "text_#{step}", label: step %>

example_app/app/views/surveys/show.html.erb

@@ -25,7 +25,11 @@
       <li>
         <%= form.fields_for "answers_attributes[#{question.id}]", Answer.new do |submission_fields| -%>
           <%= submission_fields.label :text, label: question.title %>
-          <%= render question, submission_fields: submission_fields %>
+          <%= render(
+            question,
+            submission_fields: submission_fields,
+            submittable: question.submittable
+          ) %>
           <%= link_to 'Edit', edit_question_path(question) %>
         <% end -%>
       </li>