Remove extra space from SchemaDumper.dump output

scenic-views · Jul 16, 2018 · 07b1580 · 07b1580
1 parent a21c476
commit 07b1580
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/lib/scenic/view.rb b/lib/scenic/view.rb
@@ -45,7 +45,7 @@ def to_schema
       materialized_option = materialized ? "materialized: true, " : ""
 
       <<-DEFINITION
-  create_view #{name.inspect}, #{materialized_option} sql_definition: <<-\SQL
+  create_view #{name.inspect}, #{materialized_option}sql_definition: <<-\SQL
     #{definition.indent(2)}
   SQL
       DEFINITION

diff --git a/spec/scenic/schema_dumper_spec.rb b/spec/scenic/schema_dumper_spec.rb
@@ -15,7 +15,8 @@ class SearchInAHaystack < ActiveRecord::Base
     ActiveRecord::SchemaDumper.dump(Search.connection, stream)
 
     output = stream.string
-    expect(output).to include 'create_view "searches"'
+
+    expect(output).to include 'create_view "searches", sql_definition: <<-SQL'
     expect(output).to include view_definition
 
     Search.connection.drop_view :searches
@@ -25,6 +26,19 @@ class SearchInAHaystack < ActiveRecord::Base
     expect(Search.first.haystack).to eq "needle"
   end
 
+  it "dumps a create_view for a materialized view in the database" do
+    view_definition = "SELECT 'needle'::text AS haystack"
+    Search.connection.create_view :searches, materialized: true, sql_definition: view_definition
+    stream = StringIO.new
+
+    ActiveRecord::SchemaDumper.dump(Search.connection, stream)
+
+    output = stream.string
+
+    expect(output).to include 'create_view "searches", materialized: true, sql_definition: <<-SQL'
+    expect(output).to include view_definition
+  end
+
   context "with views in non public schemas" do
     it "dumps a create_view including namespace for a view in the database" do
       view_definition = "SELECT 'needle'::text AS haystack"