Add Rails 4 support. #19

Merged
merged 1 commit into from Apr 13, 2013

Projects

None yet

3 participants

Contributor
caike commented Dec 21, 2012

Mix shoulda-context in MiniTest::Spec if present and part of ActiveSupport::TestCase's ancestors.

This is a simple suggestion for adding support to upcoming Rails 4, which now has its base test class inheriting from MiniTest::Spec instead of Test::Unit::TestCase.

I'm not expecting this pull-request to merged right away, as it doesn't include any tests or Appraisal support for Rails 4, but I'd love to hear your thoughts on this approach.

@caike caike Add Rails 4 support.
Mix shoulda-context in MiniTest::Spec if present and part of ActiveSupport::TestCase's ancestors.
350e852
Neku commented Apr 13, 2013

When this will be merged?

@travisjeffery travisjeffery merged commit bd69be2 into thoughtbot:master Apr 13, 2013

1 check passed

default The Travis build passed
Details
Collaborator

Done.

Neku commented Apr 13, 2013

That was fast 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment