Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

shoulda-context is incompatible with shoulda-matchers >= 1.5 #22

Merged
merged 1 commit into from Apr 1, 2013

Conversation

Projects
None yet
2 participants

rmm5t commented Apr 1, 2013

This commit broke assert_accepts and assert_rejects. Since shoulda.gemspec allows for matchers >= 1.4.1 gem install shoulda will be broken 😿

Collaborator

rmm5t commented Mar 31, 2013

@sshaw Thanks for reporting this. It sounds like you've spent some time investigating this, so I'd like to propose a course of action for your review:

  1. Update shoulda-context to use the new matcher api that's represented in shoulda-matchers 1.5.
  2. Release a new shoulda-context v1.1.0
  3. Release a new shoulda v3.5.0 that relies on shoulda-context ~> 1.1 and shoulda-matchers ~> 1.5

Interestingly though, I have an app that relies on shoulda-context 1.0.2 and shoulda-matchers 1.5.4. but I'm not experiencing any errors. I'll have to figure out why that is.

@rmm5t rmm5t referenced this pull request in thoughtbot/shoulda-matchers Mar 31, 2013

Closed

RSpec 2.10 compatibility #108

Added support for modern matcher syntax
* `failure_message` renamed to `failure_message_for_should`
* `negative_failure_message` renamed to `failure_message_for_should_not`

Adds support for shoulda-matchers >= 1.5, but also keeps support for
shoulda-matchers < 1.5.
Collaborator

rmm5t commented Apr 1, 2013

I just attached code to this issue that adds support for the more modern matcher syntax, but also keeps support for the older syntax (just in case). New shoulda-context 1.1.0 release coming soon.

rmm5t added a commit that referenced this pull request Apr 1, 2013

Merge pull request #22 from thoughtbot/modern-matcher-syntax
shoulda-context is incompatible with shoulda-matchers >= 1.5

@rmm5t rmm5t merged commit 7c403fa into master Apr 1, 2013

1 check passed

default The Travis build passed
Details

@rmm5t rmm5t deleted the modern-matcher-syntax branch Apr 1, 2013

Collaborator

rmm5t commented Apr 1, 2013

shoulda-context 1.1.0 is now on rubygems. bundle update shoulda-context. Let me know if you have any trouble with it.

sshaw commented Apr 2, 2013

Just updated, it's now working, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment