Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on Sep 12, 2012
  1. @drapergeek @gabebw

    Set the value for the failing attribute

    drapergeek authored gabebw committed
  2. @drapergeek @gabebw

    WIP: Fix positve error description spec issues and add method for mat…

    drapergeek authored gabebw committed
  3. @gabebw

    WIP: Positive error description

    gabebw authored
    Currently AllowValueMatcher has a commented-out example usage, which should be
    uncommented when this is ready.
    Ideally the `if expected_message` nil-check in AllowValueMatcher will be handled
    by PositiveErrorDescription too.
    Use it in FormattedErrorDescription as well.
    We use PositiveErrorDescription#matches? and #matched_error to grab the
    description and return the correct thing in FormattedErrorDescription. I
    envision FormattedErrorDescription being used in AllowValueMatcher too, probably
    with a #matches? method too that delegates.
  4. @gabebw

    WIP-WIP-WIP: extract formatted error message to a third class

    gabebw authored
    Currently Dis/allowValueMatcher uses the mixed-in pretty_error_messages method.
    Since DisallowValueMatcher isn't a perfect logical inverse of AllowValueMatcher,
    we need to have a third class that handles error messages for us.
    Future thoughts:
    Have a PositiveErrorDescription and a NegativeErrorDescription, which will
    compose FormattedErrorMessageList into a "Did not expect errors, got errors: "
    vs "Expected errors, got no errors". Idea: one of them can decorate the other
    and return the other's negative message as its positive message and vice versa.
  5. @gabebw
  6. @gabebw
  7. @gabebw
  8. @gabebw
  9. @gabebw


    gabebw authored
  10. @gabebw

    Test pretty_error_messages.

    gabebw authored
  11. @gabebw

    Test for the correct thing.

    gabebw authored
  12. @gabebw


    gabebw authored
  13. @gabebw
  14. @gabebw

    Allow bundler 1.2.0.pre.

    gabebw authored
  15. @drapergeek @gabebw
  16. @gabebw

    A bit of cleanup.

    gabebw authored
  17. @drapergeek @gabebw

    WIP: refactor shoulda matchers

    drapergeek authored gabebw committed
  18. @drapergeek @gabebw

    WIP: refactor shoulda matchers

    drapergeek authored gabebw committed
  19. @drapergeek @gabebw
  20. @gabebw

    Add tests for CompositeMatcher.

    gabebw authored
  21. @drapergeek @gabebw

    WIP: start using composite pattern.

    drapergeek authored gabebw committed
Commits on Aug 30, 2012
  1. @joshuaclayton

    Bump version to 1.3.0

    joshuaclayton authored
Commits on Aug 14, 2012
  1. @fabiokr @gylaz

    Merge pull request #140

    fabiokr authored gylaz committed
    * Allows to use the validate_format_of matcher with allow_blank and allow_nil options
    * Fixup test descriptions
    * Remove duplicate entry from news
Commits on Jul 27, 2012
  1. @gabebw

    Merge pull request #136 from potomak/patch-1

    gabebw authored
    Remove duplicate spec; add in_array
  2. @gabebw

    Merge pull request #136 from potomak/patch-1

    gabebw authored
    Remove duplicate spec; add in_array
Commits on Jul 25, 2012
  1. @potomak
Commits on Jul 20, 2012
  1. @gabebw

    Update NEWS file.

    gabebw authored
  2. @elliterate @gabebw

    Removed old Rails 2.x layout lookup.

    elliterate authored gabebw committed
    Fixes render_with_layout matcher when rendering with only a partial.
    (Rendering with :layout => false would also have had this problem on
    Edge Rails.)
  3. @gabebw

    Update NEWS file.

    gabebw authored
Commits on Jul 11, 2012
  1. @mike-burns

    Mix RSpec with Test::Unit

    mike-burns authored
    An edge case occurs when mixing RSpec and Test::Unit tests and also
    loading both the 'rspec-rails' gem and 'shoulda-matchers' gem from the
    same Gemfile group, namely [:test, :development] . Work around this by
    always inserting the shoulda matchers into Test::Unit, regardless of
    whether RSpec is loaded.
Commits on Jul 10, 2012
  1. @mike-burns
  2. @mike-burns
  3. @mike-burns
Commits on Jul 9, 2012
  1. @danieltamiosso @mike-burns

    Add a #validate check for association matchers

    danieltamiosso authored mike-burns committed
  2. @elliterate @mike-burns

    Restore uniqueness scope values after verifying each scope.

    elliterate authored mike-burns committed
    A test for a validation with multiple scopes would always pass as long
    as there was a validation with the first scope. Subsequent scopes would
    pass verification because the first scope value had already been made
Something went wrong with that request. Please try again.