When running tests, you can now switch between running them against a SQLite or PostgreSQL database. This is accomplished by modifying the unit and acceptance tests so that when they generate and load the test Rails application, database.yml is replaced with content that will configure the database appropriately.
* Ruby 2.2 removed Minitest and Test::Unit from the standard library [], [] * rspec-rails requires Test::Unit for Rails versions prior to 4.1 (which switched to Minitest) * This doesn't work now, because we don't have Test::Unit present in the gem bundle * RSpec 3.2.0 fixes this issue [] I don't really see this as a huge concern, since we were testing against RSpec 2.99 for Rails < 4, and that has most of the changes that RSpec 3 has. : ruby/ruby@f8c6a5d : ruby/ruby@96f5526 : rspec/rspec-rails@999ebb7#diff-08d960c572ac094640dd183fa9641393R13
debugger and byebug cannot be present in Appraisals because they only work on specific Ruby versions, and we test against a range of Ruby versions. Hence, they can't be present in the Rails application that gets generated in acceptance tests, either. Also, we don't really need web-console to be there, it's just an extra dependency.
Given this scenario: * Using Rails 4.1 * Gemfile has `gem 'shoulda-matchers', require: false` * spec_helper has `require 'shoulda/matchers'` following `require 'rspec/rails'` * Using Spring to run tests matchers that delegate to assertions in Rails (e.g. `render_template` and `route`) will fail in the wrong way if used. They fail because in order to use these assertions, we expect that the assertions will raise a specific exception, an exception that corresponds to whichever test framework that Rails is using. For Rails versions that used Test::Unit, this is Test::Unit::AssertionFailedError. For current Rails versions, which now use Minitest, this exception is Minitest::Assertion. The problem is that instead of asking Rails which exception class it's using, we are trying to detect this exception class ourselves (for cases in which Rails is not being used). This leads to the wrong class being detected: when using a Rails version that uses Minitest, we choose Test::Unit::AssertionFailedError as the class. This happens using the exact scenario above because even though shoulda-matchers is loaded after rspec-rails, rspec-rails itself defines Test::Unit::AssertionFailedError. Also add Cucumber tests that confirms this exact scenario works.
Since as of commit 2748b75, we no longer install dependencies inside of the Rails app that is generated and used to run all of the tests, we have to require all of the dependencies that the app would install inside of the appropriate Appraisals. This was mostly straightforward except for some workarounds with the turn gem: * Rails 3.1 requires two versions of turn depending on which Ruby version you're using. On 1.9.2, it uses turn 0.9.2; after 1.9.2, it uses ~> 0.9.3. To accommodate this we have to have two versions of the Rails 3.1 appraisal which declare the different turn versions. * Rails 3.1 also loads the turn gem even if, in the Gemfile for the app, turn is declared with `require: false`. This causes a problem while running our tests because turn actually requires minitest/autorun, which adds a hook so when Ruby exits, Minitest tests are run. Because we're already using RSpec, Minitest will try to re-run the `rspec` command we ran within a Minitest environment. This will fail since we are using RSpec-specific command line options to run the tests. Unfortunately there's no way to shut off minitest/autorun after it's been required, so we have to monkey-patch Minitest's #run method so it's a no-op.
As reported in #348, model#valid? is called with one argument while ActiveResource::Validations only defines #valid? without an optional argument. The interface of ActiveResouce::Validations#valid? is the same for A'resource in Rails 3.2 and the one extracted into a gem. Rails 3.2 version: https://github.com/rails/rails/blob/3-2-stable/activeresource/lib/active_resource/validations.rb#L123 Gem version: https://github.com/rails/activeresource/blob/master/lib/active_resource/validations.rb#L160
Rails 4 includes strong parameters and removed attr_accessible (protected attributes). I removed the strong_parameters development dependency and added it to all non-4.0 appraisals. I also added the 'protected_attributes' gem to the 4.0 appraisal because the test suite examples make heavy use of attr_accessible.
…c_helper.rb to respect a BUNDLE_GEMFILE set on the command line.
…ndencies in `Appraisal` file.
…s version Note that we also bump RSpec to 2.6.1.beta1 because the incompatibility with Rails 3.1.0.rc1