Skip to content


Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Comparing changes

Choose two branches to see what's changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
base fork: thoughtbot/shoulda-matchers
head fork: thoughtbot/shoulda-matchers
Checking mergeability… Don't worry, you can still create the pull request.
Commits on Sep 13, 2012
@jferris jferris Extract ValidationMessageFinder from AllowValueMatcher 3dbf5d4
@jferris jferris Extract ExceptionMessageFinder from AllowValueMatcher
* Replaces repeated conditional with polymorphism
@jferris jferris Fix failure on 1.8.7 1ca1f72
Commits on Sep 14, 2012
@jferris jferris Add documentation for strict validation testing fde078d
Adarsh Pandit Update Copyright year a74cee3
@grosser grosser Protect against unmatchable classes in flash matcher 27841b7
Commits on Sep 21, 2012
@steveklabnik steveklabnik Refactor have_db_index_matcher#correct_unique?
Currently, there is an assumption that `matched_index.unique` will
be `true` and not truthy. This is not always the case. This can
cause tests to fail, even though they should pass. This allows
`matched_index.unique` to be truthy.
@gauravs gauravs Don't assume that the column is of integer type
Postgres adapter does not convert integers to string upon assignment, so initialize with correct value.
@karledurante karledurante Using ActiveRecord::Base.connection is presumptuous. You must infer t…
…he home of the join table using the parent model. This allows developers to define HABTM relationships in other databases and still use the 'have_and_belong_to_many' matcher.
@grk grk Add in_array to ensure_exclusion_of 8a477a9
@jacobsimeon jacobsimeon add custom foreign key test cf6452d
@jacobsimeon jacobsimeon don't conflict with the pre-existing method 1b31a06
@jacobsimeon jacobsimeon allow testing of :foreign_key option for has_one relationships ca8a1e5
@jesseplusplus jesseplusplus Fix ensure_length_of matcher to work for is_equal_to cases when the a…
…ttribute has other validations on it.

Now that the upper bound matchers are not being skipped for the is_equal_to case, the expected error message needs to be set for the upper bound.
@grantovich grantovich Don't lock Bundler at minor version b658c4b
@grantovich grantovich Whoops, don't use Bundler 1.0 2c214e4
@grantovich grantovich [#120] Test more blank values with allow_blank 12121b8
Commits on Sep 28, 2012
@drapergeek drapergeek Model must only allow values inside of array for EnsureInclusionOf dc5daca
@gabebw gabebw Use `all?`. 7f208e7
Commits on Oct 01, 2012
@gabebw gabebw Test against Rails 3.2 in Travis. 79d8ea0
@gabebw gabebw Update appraisals to latest Rails versions. 04ce177
Commits on Oct 02, 2012
@rmm5t rmm5t Fixed the pretty_key output of the set_the_flash matcher ddcd0f5
Commits on Oct 05, 2012
@drapergeek drapergeek Try next values in array only.
If we can't find a valid next value outside of each item
in the array, throw a custom exception.
@drapergeek drapergeek Bump version to 1.4.0 e5914f7
Commits on Oct 08, 2012
@drapergeek drapergeek Updated description of AllowMassAssignmentMatcher. a228e0e
Commits on Oct 15, 2012
@pjg pjg Add scoped uniqueness example to README
I keep hitting Google for the exact syntax of this.
@drapergeek drapergeek Use an arbitrary string for ensure_inclusion instead of using next fu…
@drapergeek drapergeek Don't memoize the message finder so that we can make sure there is an…
… instance when we need it
@drapergeek drapergeek Bump to version 1.4.1 f502d11
@drapergeek drapergeek Bump gemfile.lock fdf3350
Commits on Oct 19, 2012
@drapergeek drapergeek Merge pull request #171 from pjg/patch-1
Add scoped uniqueness example to README
@readeharris readeharris Add #delegate_method matcher. 2377fb4
@readeharris readeharris Respond to feedback. a117db9
@readeharris readeharris Minor style tweaks. 9565ddd
@readeharris readeharris Use begin/rescue instead of def/rescue. a4b4feb
@readeharris readeharris Clean up long lines in spec. 27ce2e2
@readeharris readeharris Use 1.8.7 style hashes. 72ed488
@readeharris readeharris Remove unnecessary line. 594ece7
@readeharris readeharris The Bourne Dependency 760b7da
@readeharris readeharris Add delegate_method to README. 86169f0
@drapergeek drapergeek Change naming to non-Rails-dependent instead of related 4b54e65
@drapergeek drapergeek Fix an issue with formatting between 1.9.3 & 1.8.7 9e1188e
Commits on Nov 05, 2012
@phlipper phlipper colorize with Github Flavored Markdown
This makes the example code easier to skim, especially on Github
Commits on Nov 09, 2012
@readeharris readeharris Use submatchers instead of inheritance for ValidatesNumericalityMatcher. 6ba8c9f
@readeharris readeharris Improve error message handling in ValidateNumericalityOfMatcher and O…
Commits on Nov 30, 2012
@drapergeek drapergeek Bump to version 1.4.2 564575d
@drapergeek drapergeek Add in the Gemfile after the version bump. 656714c
Commits on Dec 03, 2012
@sferik sferik Don't test REE [ci skip]
Ruby Enterprise Edition has reached its end of life and should be fully
compatible with MRI 1.8.7. Testing on both is wasting resources. See:
@sferik sferik Update rake dependency to >= 0.9.2 82c0cb7
@sferik sferik Update cucumber dependency to ~> 1.1 c8cbd36
@sferik sferik Update appraisal dependency to version ~> 0.4 2f241a5
@sferik sferik The Bourne Supremacy bbb0f45
@sferik sferik Update 3.0.gemfile.lock 181efb3
@sferik sferik Update 3.1.gemfile.lock ac505cd
@sferik sferik Update 3.2.gemfile.lock dfcf777
@sferik sferik Update Gemfile.lock f717566
Commits on Dec 20, 2012
@gabebw gabebw Remove unused spec/fixtures/ bc84d55
@gabebw gabebw Formatting 891018f
@gabebw gabebw Mimic lib/ structure in spec/ 5d835e8
Commits on Dec 25, 2012
@hron hron Rewritten rspec integration to use RSpec's configure for matchers loa…
@gabebw gabebw Update cc03053
Commits on Dec 27, 2012
@gabebw gabebw Use current thoughtbot style in specs af8f9a7
@drapergeek drapergeek WIP: start using composite pattern. c79f667
@gabebw gabebw Add tests for CompositeMatcher. 0ee0d48
@drapergeek drapergeek move with message matcher into seperate file and fix issue with nil m…
@gabebw gabebw wip 6d81390
@gabebw gabebw Expose more of CompositeMatcher API bfff118
@gabebw gabebw WIP: DisallowValueMatcher. 1a3ee83