Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update validator matchers to use Rails 3 style validator #146

Closed
sikachu opened this Issue Aug 29, 2012 · 5 comments

Comments

Projects
None yet
6 participants
Contributor

sikachu commented Aug 29, 2012

I think it's time for us to move on from Rails 2 style validator detection. On Rails 3, we have Model.validators_on(:attribute), which will return the validators on that particular attribute. We can access its properties, and also its :kind there.

However, doing so would mean that we're removing Rails 2 support, so I'd like to hear on what you guys think about this major bump.

That's pretty slick, I hadn't realized that method was available.

Contributor

gabebw commented Aug 29, 2012

I like this. We've removed Rails 2 support on Paperclip and factory_girl already, and those are way more popular than shoulda-matchers. 👍

👍

Contributor

PikachuEXE commented Jan 14, 2013

Any update on this?

Owner

drapergeek commented May 3, 2013

I think this is an ongoing fix and I would be fine with doing this as things go along. I'm going to close this as an actual issue though because its not something we will 'check off'.

@drapergeek drapergeek closed this May 3, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment