Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Update validator matchers to use Rails 3 style validator #146

Closed
sikachu opened this Issue · 5 comments

6 participants

@sikachu
Owner

I think it's time for us to move on from Rails 2 style validator detection. On Rails 3, we have Model.validators_on(:attribute), which will return the validators on that particular attribute. We can access its properties, and also its :kind there.

However, doing so would mean that we're removing Rails 2 support, so I'd like to hear on what you guys think about this major bump.

@calebthompson

That's pretty slick, I hadn't realized that method was available.

@gabebw
Owner

I like this. We've removed Rails 2 support on Paperclip and factory_girl already, and those are way more popular than shoulda-matchers. :+1:

@PikachuEXE

Any update on this?

@drapergeek
Owner

I think this is an ongoing fix and I would be fine with doing this as things go along. I'm going to close this as an actual issue though because its not something we will 'check off'.

@drapergeek drapergeek closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.