Add more parameters to ValidateNumericalityOfMatcher #44

Closed
moffff opened this Issue Dec 21, 2011 · 7 comments

5 participants

@moffff

it { should validate_numericality_of(:age).greater_than(18) }
it { should validate_numericality_of(:age).less_than(300) }
it { should validate_numericality_of(:age).greater_than_or_equal_to(18) }
it { should validate_numericality_of(:age).less_than_or_equal_to(300) }
it { should validate_numericality_of(:age).equal_to(25) }

@doriath

This is exactly what I was missing from shoulda. Are there any plans to merge this? If not, why?

@cjoudrey

👍

@fro

+1

@gabebw
thoughtbot, inc. member

@moffff: Can you make a pull request for this, and I'll take a look? Thanks!

@moffff

@gabebw: #82 - ready

@gabebw
thoughtbot, inc. member

OK, thanks. I'll take a look. I'm closing this issue to move discussion to #82.

@gabebw gabebw closed this Mar 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment