have_many :as tests

[amnesia7]

I was wondering if :as should be added to have_many.

I have

has_many :favourites, as: :favourable, dependent: :destroy

and am testing it using:

it { should have_many(:favourites).dependent(:destroy) }

Since :as isn't currently available in shoulda-matchers I've also added the following test to my spec file but I'm not sure if I should really be testing anything more as part of :as

it { should respond_to(:favourable) }

Thanks

[maurogeorge]

We are talking here about polymorphic associations right?

I think the it { should have_many(:favourites).dependent(:destroy) } is enough. Since if you change your associations to has_many :favourites, dependent: :destroy you will receive a error like:

     Failure/Error: it { is_expected.to have_many(:favourites).dependent(:destroy) }
       Expected Model to have a has_many association called favourites (Favourite does not have a model_id foreign key.)

Maybe we can add a note on the docs, like we have on the belong_to.

What you think?

[amnesia7]

Just tested without :as and failed as you say so a note on the docs sounds fine to me.

[mcmire]

Yeah, I think a note in the docs makes sense here.

[mcmire]

This was fixed a long time ago, and it looks like I forgot to close this. The commit that fixed this was: 670f154