New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove `rspec-rails` from installation example code. #117

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@justinko

justinko commented Jun 7, 2012

In order to get RSpec Rails generators in a Rails app, rspec-rails must be included in the "development" and "test" Bundler group.

Just trying to reduce confusion with RSpec Rails users ("where are the generators?!").

Remove `rspec-rails` from installation example code.
In order to get RSpec Rails generators in a Rails app, `rspec-rails` must be included in the "development" and "test" Bundler group.

Just trying to reduce confusion with RSpec Rails users ("where are the generators?!").
@gabebw

This comment has been minimized.

Show comment
Hide comment
@gabebw

gabebw Jun 7, 2012

Contributor

I'm confused - for shoulda to work, all you need is to have rspec-rails in the :test group - that doesn't prevent it from being in the :development group.

Maybe I misunderstood you, but I don't think shoulda should be responsible for users installing rspec-rails correctly.

Contributor

gabebw commented Jun 7, 2012

I'm confused - for shoulda to work, all you need is to have rspec-rails in the :test group - that doesn't prevent it from being in the :development group.

Maybe I misunderstood you, but I don't think shoulda should be responsible for users installing rspec-rails correctly.

@gabebw gabebw closed this Jun 7, 2012

@justinko

This comment has been minimized.

Show comment
Hide comment
@justinko

justinko Jun 8, 2012

If you want to keep rspec-rails in your installation documentation, it should be like this:

group :development, :test do
  gem 'rspec-rails'
end

group :test do
  gem 'shoulda-matchers'
end

OR

gem 'rspec-rails', :groups => [:development, :test]
gem 'shoulda-matchers', :group => :test

I have commit access to RSpec. I can't count the number of times users have reported "the generators aren't available in my app". To get the generators, rspec-rails needs to be in the :development bundle group.

As I said before, just trying to avoid confusion for RSpec users.

justinko commented Jun 8, 2012

If you want to keep rspec-rails in your installation documentation, it should be like this:

group :development, :test do
  gem 'rspec-rails'
end

group :test do
  gem 'shoulda-matchers'
end

OR

gem 'rspec-rails', :groups => [:development, :test]
gem 'shoulda-matchers', :group => :test

I have commit access to RSpec. I can't count the number of times users have reported "the generators aren't available in my app". To get the generators, rspec-rails needs to be in the :development bundle group.

As I said before, just trying to avoid confusion for RSpec users.

@alindeman

This comment has been minimized.

Show comment
Hide comment
@alindeman

alindeman Jun 8, 2012

rspec-rails in [:development, :test] is generally what you want, agreed.

alindeman commented Jun 8, 2012

rspec-rails in [:development, :test] is generally what you want, agreed.

@gabebw gabebw reopened this Jun 8, 2012

@gabebw

This comment has been minimized.

Show comment
Hide comment
@gabebw

gabebw Jun 8, 2012

Contributor

Do you want to change your pull request to put rspec-rails in both groups, instead of removing it? I'd merge that.

Contributor

gabebw commented Jun 8, 2012

Do you want to change your pull request to put rspec-rails in both groups, instead of removing it? I'd merge that.

@justinko

This comment has been minimized.

Show comment
Hide comment
@justinko

justinko Jun 8, 2012

I don't care about the contribution. So, if you could do that, that would be great!

justinko commented Jun 8, 2012

I don't care about the contribution. So, if you could do that, that would be great!

@gabebw gabebw closed this in 2185ea3 Jun 8, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment