Allow matched_index.unique to be truthy.

[steveklabnik]

Currently, there is an assumption that matched_index.unique will
be true and not truthy. This is not always the case. This can
cause tests to fail, even though they should pass. This allows
matched_index.unique to be truthy.

This is just a first go to see what you think, I'm more than happy to adjust, as I've never even used shoulda before, to be honest.

This was inspired by https://groups.google.com/forum/?fromgroups=#!topic/rubyonrails-core/MM3Lh2M8QBE , more information is there.

[mike-burns]

That's a good catch, thanks. Is it possible to add a test for this?

[steveklabnik]

I think so. Let me try.

[steveklabnik]

Hm. The existing tests operate at a pretty high level, and I'm not sure what your style is of testing this kind of thing. Normally, I would stub matched_index to return a number; do you think this is possible?

[mike-burns]

We try to avoid stubbing the object under test. How about stubbing something on ActiveRecord::Base.connection.indexes?

[steveklabnik]

Sure thing. Let me just figure out how you guys stub things...

[steveklabnik]

It looks like stub("ActiveRecord::Base", :connection => stub("Foo", :indexes => nil)) is the way to do it?

[mike-burns]

We use mocha for this project, so that seems close. But I think it's:

columns = [] # whatever is needed to make this test fail
indexes = stub('indexes', :columns => columns)
ActiveRecord::Base.stubs(:connection).returns(stub('connection', :indexes => indexes))

[steveklabnik]

Whew, this is looking nasty. Any thoughts? Am I on the right track?

    stub("ActiveRecord::Base", :connection => stub("Foo", :indexes => stub("bar", :columns => [:age])))

    db_connection = create_table 'superheros' do |table|
      table.integer :age
    end

    define_model_class 'Superhero'
    Superhero.new.should have_db_index(:age).unique(true)

[mike-burns]

That all seems right except for the first line; the stub. Since we're referencing the ActiveRecord::Base object directly we stub it like this:

ActiveRecord::Base.stubs(:connection => ...)

[steveklabnik]

Ahhh, I was trying to use AR::Base.stub and it threw an error, I need stubs.

I'm leaving for the Frozen Rails party at the moment, but I'll try to complete this in a few hours. ;)

[mike-burns]

Oh I should do that too.

[steveklabnik]

So the issue with doing that is that trying to define the table throws errors on the connection. Since it's now a mock.

:(

[mike-burns]

Arhhhh. Right.

OK, stub the SUT, and hopefully the test's description will explain why we're doing such a crazy thing.

[steveklabnik]

Updated. Lemme know what you think. Confirmed that it fails without my refactoring, passes with.

[mike-burns]

Merged, thanks!

[steveklabnik]

Woot!