Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Specify pessimistic version constraint with two digits of precision #234

Merged
merged 1 commit into from

3 participants

@sferik

Assumes semantic versioning of shoulda-context and shoulda-matchers. See also: #232.

@sferik sferik Specify pessimistic version constraint with two digits of precision
Assumes semantic versioning of `shoulda-context` and `shoulda-matchers`.
See also: thoughtbot/shoulda#232.
b180166
@rmm5t rmm5t merged commit 2bc08cf into thoughtbot:master
@rmm5t
Owner

Thanks Erik!

@sferik

@rmm5t Thanks for the quick merge! Any plans to release a new version of the gem?

@rmm5t
Owner

No problem. I don't actually have gem push rights, so not sure about the version bump plans, but I'd like to see a new version soon, especially if someone can get the Travis-CI build passing.

@sferik

Does it make sense to reopen #232 and maybe create a separate issue to release a new version?

@rmm5t
Owner

Either reopening #232 with new code or even a whole new clean PR to fix the travis build would be great.

Separate issue for a new version? I suppose it doesn't hurt -- I don't have strong feelings either way.

@croaky, @cpytel, @jferris, et al, If you want to give me gem-push rights, I'd be happy to help manage the new version bumps for the shoulda-* suite. I know you guys are more focused on just rspec + shoulda-matchers nowadays anyway.

@croaky
Owner

@rmm5t Just gave you gem push access for shoulda, shoulda-context, and shoulda-matchers.

@rmm5t rmm5t referenced this pull request
Closed

Bump version to 3.4.0 #236

@rmm5t
Owner

Thanks @croaky.

@sferik See #235 and #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 16, 2013
  1. @sferik

    Specify pessimistic version constraint with two digits of precision

    sferik authored
    Assumes semantic versioning of `shoulda-context` and `shoulda-matchers`.
    See also: thoughtbot/shoulda#232.
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 shoulda.gemspec
View
4 shoulda.gemspec
@@ -18,8 +18,8 @@ Gem::Specification.new do |s|
s.executables = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
s.require_paths = ["lib"]
- s.add_dependency("shoulda-context", "~> 1.0.1")
- s.add_dependency("shoulda-matchers", "~> 1.4.1")
+ s.add_dependency("shoulda-context", ["~> 1.0", ">= 1.0.1"])
+ s.add_dependency("shoulda-matchers", ["~> 1.0", ">= 1.4.1"])
s.add_development_dependency('appraisal', '~> 0.4.0')
s.add_development_dependency("rails", "3.0.12")
Something went wrong with that request. Please try again.