Permalink
Commits on Nov 13, 2015
  1. @croaky

    Use Heroku Local (Forego) instead of Foreman

    Heroku Local has replaced Foreman in the Heroku Toolbelt.
    
    https://devcenter.heroku.com/changelog-items/692
    
    The command `heroku local` has replaced `foreman`.
    Heroku Local makes use of [Forego] to accomplish its tasks
    and it is faster and has better cross-platform support.
    
    [Forego]: https://github.com/ddollar/forego
    croaky committed Nov 13, 2015
Commits on Sep 18, 2015
  1. @croaky @tute

    Don't use port 5000 as an option

    OS X Yosemite uses port 5000 for AirPlay streaming.
    Running Rails on port 5000 will add noise to the backtrace such as:
    
    ```
    HTTP parse error, malformed request ():
    ENV:
    {"rack.version"=>[1, 1], "rack.errors"=>#<IO:<STDERR>>,
    "rack.multithread"=>true, "rack.multiprocess"=>false,
    "rack.run_once"=>false, "SCRIPT_NAME"=>"", "CONTENT_TYPE"=>"text/plain",
    "QUERY_STRING"=>"txtAirPlay&txtRAOP", "SERVER_PROTOCOL"=>"HTTP/1.1",
    "SERVER_SOFTWARE"=>"2.11.2", "GATEWAY_INTERFACE"=>"CGI/1.2",
    "REQUEST_METHOD"=>"GET", "REQUEST_PATH"=>"/info",
    "REQUEST_URI"=>"/info?txtAirPlay&txtRAOP"}
    ```
    
    http://stackoverflow.com/questions/31194909/http-parse-errors-coming-from-airplay
    
    [fixes #616]
    croaky committed with tute Sep 16, 2015
Commits on Jun 12, 2015
  1. @croaky

    Add default .hound.yml file

    * Enable all languages explicitly by default.
    * Help avoid configuration mistakes by providing this stub
      and a link to the configuration page.
    croaky committed Jun 12, 2015
  2. @croaky

    Improve test suite speed

    * Run Suspenders only once in `new_project_spec.rb`.
    * Should be about 17x faster.
    * Requires moving some of the RSpec `before` contents around
      to avoid RSpec hanging.
    croaky committed Jun 12, 2015
Commits on Apr 8, 2015
  1. @croaky

    Only display user-facing flashes

    We sometimes use the flash for things such as
    "sign up" in order to send data to analytics systems
    such as Mixpanel.
    
    We've then ended up doing the following on a number of projects.
    croaky committed Jan 28, 2015
Commits on Mar 7, 2015
  1. @croaky

    Update thoughtbot section of README

    * Include 2015 in the copyright.
    * Update logo to use new HTTPS version.
    * Change header from "Credits" to "About thoughtbot".
    * Move "thank you" to contributors section.
    * Make "About thoughtbot" the last thing in the README,
      with the copyrights grouped closer to the LICENSE information.
    * Link to LICENSE.
    * Make the community link more obvious that we have other projects.
    * Finish with a CTA to hire us.
    * Include `utm_source` codes to improve tracking.
    croaky committed Mar 7, 2015
Commits on Feb 4, 2015
  1. @croaky

    v1.24.0

    croaky committed Feb 4, 2015
Commits on Jan 30, 2015
  1. @croaky

    Refer to Hound in addition to thoughtbot/guides

    * It's unreasonable to expect contributors to
      read and comprehend thoughtbot/guides.
    * It's reasonable to expect they should fix Hound violations.
    * Shorten a few other sentences.
    * Delete unnecessary words.
    * Move note about Ruby version inside `CONTRIBUTING.md` document.
    croaky committed Jan 28, 2015
Commits on Jan 19, 2015
  1. @croaky

    v1.23.0

    croaky committed Jan 19, 2015
Commits on Jan 12, 2015
  1. @croaky

    v1.22.0

    croaky committed Jan 12, 2015
  2. @croaky

    Set default_url_options to ENV["HOST"] on servers

    croaky committed Jan 5, 2015
Commits on Jan 7, 2015
  1. @croaky

    Create Hound-compliant config/unicorn.rb

    Fix:
    
    > Line is too long. [91/80]
    
    Fix:
    
    > Unused block argument - server.
    > Unused block argument - worker.
    > You can omit all the arguments if you don't care about them.
    croaky committed Jan 7, 2015
Commits on Jan 5, 2015
  1. @croaky

    Improve SMTP_DOMAIN comment

    In Heroku's docs for
    [Mandrill](https://devcenter.heroku.com/articles/mandrill) and
    [SendGrid](https://devcenter.heroku.com/articles/sendgrid#ruby-rails),
    they suggest using `heroku.com`.
    
    Make this clearer for implementers.
    croaky committed Jan 4, 2015
Commits on Jan 4, 2015
  1. @croaky

    v 1.21.0

    croaky committed Jan 4, 2015
  2. @croaky

    Install Refills and Refills' "flashes" component

    croaky committed Dec 4, 2014
  3. @croaky

    Use only rails_stdout_logging, not rails_12factor

    Rails 4.2.0 uses a `ENV['RAILS_SERVE_STATIC_FILES']` variable
    to determine by default whether to server static files.
    We should use that community convention
    rather than the `rails_serve_static_assets` gem,
    which is loaded by `rails_12factor`.
    Removing that coupling also allows non-Heroku users
    to use this convention.
    
    When we remove our reliance on that gem,
    the remaining half of `rails_12factor` that we still want to use
    in Heroku environments is the `rails_stdout_logging` gem.
    
    Extract a `serve_static_files_line` helper method
    as a way to reliably append to
    the `config/environments/production.rb` file.
    
    Use double quotes instead of single quotes on changed lines
    and the lines around them.
    croaky committed Dec 28, 2014
Commits on Dec 4, 2014
  1. @croaky

    Add `bin/deploy` script

    * Help avoid forgetting to run `rake db:migrate`.
    * Help avoid forgetting to run `restart` after migrate.
    * Allow each app to edit these deploy instructions to fit their
      environments' needs (such as `run rake purge` to clear a cache)
      but maintain the same `./bin/deploy` interface and convention
      that is consistent with our many Middleman and Rails apps.
    * Use the shebang line for POSIX sh.
    * Default the argument to 'staging'
    croaky committed Oct 31, 2014
Commits on Nov 26, 2014
  1. @croaky

    v.1.20.0

    croaky committed Nov 26, 2014
Commits on Nov 24, 2014
  1. @croaky
Commits on Nov 23, 2014
  1. @croaky

    v1.19.0

    croaky committed Nov 23, 2014
Commits on Nov 14, 2014
  1. @croaky

    Use Heroku-recommended timeout numbers

    Rename ENV variables to be very explicit.
    Couples their names to their libraries.
    croaky committed Nov 14, 2014
Commits on Nov 10, 2014
  1. @croaky

    Improve memory of app on Heroku w/ New Relic

    * Help avoid R14 (Memory quota exceeded) errors.
      http://forum.upcase.com/t/how-to-free-up-swap-space-heroku/3017
    * Refactor away some duplication.
    croaky committed Nov 6, 2014
Commits on Nov 5, 2014
  1. @croaky

    Fix Bundler installation code

    Our previous Bundler idempotency code did not work
    if you had a version of Bundler installed on a different Ruby version.
    croaky committed Nov 5, 2014
Commits on Nov 3, 2014
  1. @croaky

    Remove out-of-date documentation

    croaky committed Nov 3, 2014
Commits on Oct 23, 2014
  1. @croaky

    v1.18.0

    croaky committed Oct 23, 2014
  2. @croaky
  3. @croaky
  4. @croaky

    Fix accidental indentation

    I created this when editing the previous commit.
    croaky committed Oct 23, 2014
  5. @croaky

    Don't add staging/production remotes w/o access

    If user doesn't have access to staging or production Heroku applications,
    they do not need/want to have the Git remotes created.
    
    Real-world example:
    
    codecation/trailmix#123
    croaky committed Oct 12, 2014
Commits on Oct 3, 2014
  1. @croaky

    Remove unnecessary check for directory existence

    `mkdir -p` will no-op if the directory already exists.
    croaky committed Oct 3, 2014
Commits on Oct 1, 2014
  1. @croaky

    Improve generated bin/setup

    * Make script idempotent.
    * Fail fast with install messages and non-zero exit status.
    croaky committed Sep 30, 2014
Commits on Sep 30, 2014
  1. @croaky

    v1.17.0

    croaky committed Sep 30, 2014
  2. @croaky

    Generate a Rails 4.1.6 app

    croaky committed Sep 30, 2014
  3. @croaky

    Generate rails_helper, not spec_helper

    RSpec 3.x introduces a `spec/rails_helper.rb` file
    which contains all dependencies necessary to run specs that need Rails.
    
    https://www.relishapp.com/rspec/rspec-rails/docs/upgrade#default-helper-files
    
    Achieves the goal of "Documenting Explicit Dependencies Through Tests":
    
    http://robots.thoughtbot.com/document-explicit-dependencies-through-tests
    
    * Move Rails-specific things to rails_helper.rb.
    * Require spec_helper.rb from rails_helper.rb.
    * Remove duplication across files.
    * We do not need to require "spec_helper" manually.
      It is required for us in `.rspec`:
    
        --color
        --warnings
        --require spec_helper
    croaky committed Sep 30, 2014
Commits on Aug 16, 2014
  1. @croaky

    v1.16.0

    croaky committed Aug 16, 2014