Remove Rakefile code that runs factories_spec.rb #155

Closed
croaky opened this Issue Feb 14, 2013 · 4 comments

3 participants

@croaky
thoughtbot, inc. member

Appears to be running the spec twice.

52444eb#L0R28

@jferris
thoughtbot, inc. member

I think the idea with the Rakefile part is that it runs factories_spec.rb before everything else and fails immediately if those fail, because the tests generally won't be useful to run if the factories are invalid.

It's sort of annoying to wait for the first factory run, though, and I don't love that we're copying and pasting this file around. Anybody have thoughts on removing factories_spec.rb entirely?

@croaky
thoughtbot, inc. member

I don't think I'd miss factories_spec.rb if it gets removed. It's sometimes nice to have, but I haven't felt like it's saved my butt at any point.

@mrageh

Hey Dan

I can fix this issue and remove the factories_spec.rb

@croaky
thoughtbot, inc. member

Accomplished via #259 and thoughtbot/factory_girl#609

@croaky croaky closed this Oct 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment