Skip to content

Clean up .env and Procfile #121

Closed
wants to merge 1 commit into from

2 participants

@croaky
thoughtbot, inc. member
croaky commented Nov 17, 2012
  • Remove duplicate Procfile added in 6b48ec6. The new duplicate was not being used in the script. The older templates/Procfile was used.
  • Remove duplicate copy_file 'Procfile' command. Keep new version so there are fewer commands in non-intention-revealing method, copy_miscellaneous_files.
  • Remove output instructing user to copy sample.env to .env. This output is likely to get lost in the rest of the ouput. We also want to automate that step in #120.
  • Remove unnecessary comments: 1) No need to instruct user to copy file because they should use script/setup. 2) Do not need to add .env to .gitignore because Suspenders already ignores it. 3) Do not instruct all developers to add Heroku config variables. That is a process outside the scope of this file, better documented in https://github.com/thoughtbot/guides/tree/master/protocol.
  • Link to official documentation in sample.env.
  • Remove HOSTNAME from sample.env. Developers should be able to override the port from the command line.
@croaky croaky Clean up .env and Procfile
* Remove duplicate Procfile added in 6b48ec6. The new duplicate was
  not being used in the script. The older templates/Procfile was used.
* Remove duplicate `copy_file 'Procfile'` command. Keep new version so
  there are fewer commands in non-intention-revealing method,
  `copy_miscellaneous_files`.
* Remove output instructing user to copy sample.env to .env. This output
  is likely to get lost in the rest of the ouput. We also want to
  automate that step in #120.
* Remove unnecessary comments: 1) No need to instruct user to copy file
  because they should use script/setup. 2) Do not need to add .env to
  .gitignore because Suspenders already ignores it. 3) Do not instruct
  all developers to add Heroku config variables. That is a process
  outside the scope of this file, better documented in
  https://github.com/thoughtbot/guides/tree/master/protocol.
* Link to official documentation in sample.env.
* Remove HOSTNAME from sample.env. Developers should be able to override
  the port from the command line.
570495c
@croaky croaky closed this Nov 17, 2012
@croaky
thoughtbot, inc. member
croaky commented Nov 17, 2012

Renamed this branch and commit "Clean up" instead of "Fix", which closed the pull request unintentionally. I don't see how to re-open it. Travis is telling me the build passes, though, so I'm going to merge.

@jferris
thoughtbot, inc. member
jferris commented Nov 19, 2012

I thought that we needed to have a Procfile or apps would run with webrick when deployed. Is that not true anymore?

@croaky
thoughtbot, inc. member
@jferris
thoughtbot, inc. member
jferris commented Nov 19, 2012

Groovy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.