Update staging and production email delivery #145

Merged
merged 1 commit into from Feb 25, 2013

Conversation

Projects
None yet
2 participants
Owner

croaky commented Jan 24, 2013

  • Use recipient_interceptor gem.
  • Use the Mail gem's interceptor feature.
  • Separate SMTP from intercepting responsibilities.
  • Set up SMTP for production and staging.

http://robots.thoughtbot.com/post/40822987615/delivering-all-email-from-staging-to-a-group-email

@jferris jferris and 1 other commented on an outdated diff Jan 24, 2013

templates/override_recipient_interceptor.rb
@@ -0,0 +1,42 @@
+# == Sending Email with Override Recipient Interceptor
@jferris

jferris Jan 24, 2013

Owner

I'm uncomfortable having this code as a template that gets copied into every application. I'd much rather have a new gem that we depend on which includes this class, so that we can update it as the related APIs change, fix bugs, add features, and improve documentation without having to worry about all the copies that were created in our applications. Using a gem would also make it easier to use this from non-suspenders projects.

@croaky

croaky Jan 28, 2013

Owner

Good call. I have:

Please hold off on a re-review until we've tried the gem on a staging app for a little while.

@croaky croaky Update staging and production email delivery
* Use recipient_interceptor gem.
* Use the Mail gem's interceptor feature.
* Separate SMTP from intercepting responsibilities.
* Set up SMTP for production and staging.

http://robots.thoughtbot.com/post/40822987615/delivering-all-email-from-staging-to-a-group-email
44c01db
Owner

croaky commented Feb 25, 2013

@jferris Ready for re-review.

Owner

jferris commented Feb 25, 2013

Looking good, Dan!

And the code is good to merge, too.

croaky merged commit 44c01db into master Feb 25, 2013

1 check passed

default The Travis build passed
Details
Owner

croaky commented Feb 25, 2013

Thanks, @jferris. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment