Remove Cucumber and Capybara Webkit #81

Closed
wants to merge 4 commits into
from

Projects

None yet

5 participants

@croaky
thoughtbot, inc. member

Just use raw Capybara and RSpec, let developer choose between Cucumber, Turnip, or RSpec request specs.

croaky added some commits Jun 19, 2012
@croaky croaky Don't generate Clearance features
This commit is in preparation of removing Cucumber in a later
commit.
eef93eb
@croaky croaky Remove Cucumber
Let developer choose between Cucumber, Turnip, or RSpec request specs.
c69d175
@croaky croaky Update out of date README information
* Remove old reference to Rails 3.1 (it will generate at least a
  Rails 3.2.x app now).
* Remove reference to email_spec (removed in an earlier commit).
* Remove reference to GCC OSX installer (it is not the recommended
  method on Lion or above, also a separate concern).
* Update Copyright to include 2012.
dd3967d
@croaky croaky Use just raw Capybara
* No one argues with Capybara anymore. Whatever combo you use, you're
  using Capybara these days.
* Remove Capybara Webkit. It's easy to add when you need it (if your
  machine is set up correctly) and by removing it, we can help people
  avoid installing Qt.
3335cf2
@cpytel
thoughtbot, inc. member
@croaky
thoughtbot, inc. member

I feel like we're sold on using RSpec and Capybara for everything. That's our current default and a recommendation we stand by.

I think we're going to be making a different decision for awhile between Cucumber, Turnip, and RSpec requests and it's a good thing to stop for a minute after Suspenders creates the project and make sure we're actually making a decision to add one or the other, not just go with something we're not sure about anymore.

@cpytel
thoughtbot, inc. member
@jferris
thoughtbot, inc. member

I agree with Chad here.

Dan, I see what you mean about not being sold on cucumber, but having no default is going to just mean we do something different on every project. I also don't think we should switch suspenders to a new default until we've actually tried it and seen that it works.

@cpytel
thoughtbot, inc. member
@r00k
thoughtbot, inc. member

I'm with Joe and Chad.

Rails ships with many defaults. Suspenders embraces that idea and takes it even farther. For something that we've deemed as essential as integration testing, it feels wrong to punt on it and ask the user to make a choice.

@croaky
thoughtbot, inc. member

I shall close this pull request and prophesize that we'll be using RSpec request specs + Capybara as our new standard by September 1.

@croaky croaky closed this Jun 22, 2012
@cpytel
thoughtbot, inc. member
@sgrif

@croaky Can indeed see the future.

@cpytel
thoughtbot, inc. member

I didn't realize that we didn't ever revisit this. I say we do a new pull request that removed cucumber but leaves capybara-WebKit.

@jferris
thoughtbot, inc. member

Looks like Cucumber was removed in 8290c97.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment