Use simplecov for C0 coverage #98

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Owner

jferris commented Aug 8, 2012

  • Include simplecov gem in Gemfile, test group
  • Insert simplecov init into spec_helper.rb, env.rb
Contributor

adarsh commented Aug 8, 2012

Joe - did you add coverage to the .gitignore file?

On Wed, Aug 8, 2012 at 11:54 AM, Joe Ferris notifications@github.comwrote:

  • Include simplecov gem in Gemfile, test group
  • Insert simplecov init into spec_helper.rb, env.rb

You can merge this Pull Request by running:

git pull https://github.com/thoughtbot/suspenders simplecov

Or view, comment on, or merge it at:

#98
Commit Summary

  • Use simplecov for C0 coverage

File Changes

  • M lib/suspenders/app_builder.rb (4)
  • M templates/Gemfile_additions (1)

Patch Links

@adarshp http://twitter.com/adarshp
developer at thoughtbot, inc http://www.thoughtbot.com.
313.454.1515 (m)

Owner

jferris commented Aug 8, 2012

It was already in there.

On Wednesday, August 8, 2012 at 3:17 PM, Adarsh Pandit wrote:

Joe - did you add coverage to the .gitignore file?

On Wed, Aug 8, 2012 at 11:54 AM, Joe Ferris <notifications@github.com (mailto:notifications@github.com)>wrote:

  • Include simplecov gem in Gemfile, test group
  • Insert simplecov init into spec_helper.rb, env.rb

You can merge this Pull Request by running:

git pull https://github.com/thoughtbot/suspenders simplecov

Or view, comment on, or merge it at:

#98
Commit Summary

  • Use simplecov for C0 coverage

File Changes

  • M lib/suspenders/app_builder.rb (4)
  • M templates/Gemfile_additions (1)

Patch Links


Reply to this email directly or view it on GitHubhttps://github.com/thoughtbot/suspenders/pull/98.

@adarshp http://twitter.com/adarshp
developer at thoughtbot, inc http://www.thoughtbot.com.
313.454.1515 (m)


Reply to this email directly or view it on GitHub (#98 (comment)).

@mike-burns mike-burns and 1 other commented on an outdated diff Sep 24, 2012

lib/suspenders/app_builder.rb
@@ -2,6 +2,8 @@ module Suspenders
class AppBuilder < Rails::AppBuilder
include Suspenders::Actions
+ SIMPLECOV_INIT = %{require 'simplecov'\nSimpleCov.start 'rails'\n\n}
@mike-burns

mike-burns Sep 24, 2012

Owner

How about moving this into a separate template file or at least using a heredoc?

@croaky

croaky Oct 22, 2012

Owner

Agree on a separate template file.

jferris added some commits Aug 8, 2012

@jferris jferris Use simplecov for C0 coverage
* Include simplecov gem in Gemfile, test group
* Insert simplecov init into spec_helper.rb, env.rb
44c51c1
@jferris jferris Use a template for SimpleCov init 94c4085
Owner

jferris commented Oct 22, 2012

croaky closed this Oct 23, 2012

Owner

croaky commented Oct 23, 2012

@mike-burns @croaky Better?

Definitely. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment